You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jan 9, 2024. It is now read-only.
There are small typos in:
- CONTRIBUTING.md
- docs/development.rst
- docs/index.rst
- docs/logging.rst
- docs/pubsub.rst
- docs/upgrading.rst
- rediscluster/client.py
- rediscluster/connection.py
- tests/test_cluster_node_manager.py
- tests/test_commands.py
- tests/test_encoding_cluster.py
Fixes:
- Should read `specified` rather than `specefied`.
- Should read `implementation` rather than `impelmentation`.
- Should read `upstream` rather than `uptream`.
- Should read `iterate` rather than `itterate`.
- Should read `recommended` rather than `reccommended`.
- Should read `received` rather than `recieved`.
- Should read `preferred` rather than `preffered`.
- Should read `possibility` rather than `posiblity`.
- Should read `interval` rather than `intervall`.
- Should read `examples` rather than `exmaples`.
- Should read `documentation` rather than `documentaion`.
Closes#461
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -88,7 +88,7 @@ All tests should be assumed to work against the test environment that is impleme
88
88
89
89
## Testing strategy and how to implement cluster specific tests
90
90
91
-
A new way of having the old upstream tests from redis-py combined with the cluster specific and unique tests that is needed to validate cluster functionality. This has been designed to improve the speed of which tests is updated from uptream as new redis-py releases is made and to make it easier to port them into the cluster variant.
91
+
A new way of having the old upstream tests from redis-py combined with the cluster specific and unique tests that is needed to validate cluster functionality. This has been designed to improve the speed of which tests is updated from upstream as new redis-py releases is made and to make it easier to port them into the cluster variant.
Copy file name to clipboardExpand all lines: docs/pubsub.rst
+2-2Lines changed: 2 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -7,7 +7,7 @@ According to the current official redis documentation on `PUBLISH`::
7
7
8
8
Integer reply: the number of clients that received the message.
9
9
10
-
It was initially assumed that if we had clients connected to different nodes in the cluster it would still report back the correct number of clients that recieved the message.
10
+
It was initially assumed that if we had clients connected to different nodes in the cluster it would still report back the correct number of clients that received the message.
11
11
12
12
However after some testing of this command it was discovered that it would only report the number of clients that have subscribed on the same server the `PUBLISH` command was executed on.
13
13
@@ -60,7 +60,7 @@ This new solution is probably future safe and it will probably be a similar solu
60
60
Known limitations with pubsub
61
61
-----------------------------
62
62
63
-
Pattern subscribe and publish do not work properly because if we hash a pattern like `fo*` we will get a keyslot for that string but there is a endless posiblity of channel names based on that pattern that we can't know in advance. This feature is not limited but the commands is not recommended to use right now.
63
+
Pattern subscribe and publish do not work properly because if we hash a pattern like `fo*` we will get a keyslot for that string but there is a endless possibility of channel names based on that pattern that we can't know in advance. This feature is not limited but the commands is not recommended to use right now.
64
64
65
65
The implemented solution will only work if other clients use/adopt the same behaviour. If some other client behaves differently, there might be problems with `PUBLISH` and `SUBSCRIBE` commands behaving wrong.
Copy file name to clipboardExpand all lines: docs/upgrading.rst
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -108,7 +108,7 @@ Added new `ClusterCrossSlotError` exception class.
108
108
Added optional `max_connections_per_node` parameter to `ClusterConnectionPool` which changes behavior of `max_connections` so that it applies per-node rather than across the whole cluster. The new feature is opt-in, and the existing default behavior is unchanged. Users are recommended to opt-in as the feature fixes two important problems. First is that some nodes could be starved for connections after max_connections is used up by connecting to other nodes. Second is that the asymmetric number of connections across nodes makes it challenging to configure file descriptor and redis max client settings.
109
109
110
110
Reinitialize on `MOVED` errors will not run on every error but instead on every
111
-
25 error to avoid excessive cluster reinitialize when used in multiple threads and resharding at the same time. If you want to go back to the old behaviour with reinitialize on every error you should pass in `reinitialize_steps=1` to the client constructor. If you want to increase or decrease the intervall of this new behaviour you should set `reinitialize_steps` in the client constructor to a value that you want.
111
+
25 error to avoid excessive cluster reinitialize when used in multiple threads and resharding at the same time. If you want to go back to the old behaviour with reinitialize on every error you should pass in `reinitialize_steps=1` to the client constructor. If you want to increase or decrease the interval of this new behaviour you should set `reinitialize_steps` in the client constructor to a value that you want.
112
112
113
113
Pipelines in general have received a lot of attention so if you are using pipelines in your code, ensure that you test the new code out a lot before using it to make sure it still works as you expect.
0 commit comments