Skip to content

feat: update functions samples #10197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: update functions samples #10197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb9cc8a
feat: update functions samples
maigovannon Nov 3, 2025
b0b9764
Fixing PubSub for Java21 compatibility
maigovannon Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions functions/helloworld/helloworld/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@
<!-- [START functions_example_pom] -->
<!-- [START functions_example_pom_dependencies] -->
<properties>
<maven.compiler.target>11</maven.compiler.target>
<maven.compiler.source>11</maven.compiler.source>
<maven.compiler.target>21</maven.compiler.target>
Copy link
Contributor

@iennae iennae Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generally do not have samples for every run time in Functions. Java 11 is the minimum required runtime https://docs.cloud.google.com/run/docs/runtimes/java and that's why this is 11 currently. If y'all are thinking to move to latest supported (non-preview) that's fine, but it would be helpful to know that's the intent here. We should not have duplicate samples showing the basic usecase.

Copy link
Author

@maigovannon maigovannon Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java11 is actually no longer supoprted and was decommissioned on 10/31: https://docs.cloud.google.com/run/docs/runtime-support#java

<maven.compiler.source>21</maven.compiler.source>
</properties>

<dependencies>
Expand Down
23 changes: 21 additions & 2 deletions functions/v2/pubsub/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@
</parent>

<properties>
<maven.compiler.target>11</maven.compiler.target>
<maven.compiler.source>11</maven.compiler.source>
<maven.compiler.target>21</maven.compiler.target>
<maven.compiler.source>21</maven.compiler.source>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
</properties>

Expand Down Expand Up @@ -100,6 +100,25 @@
<functionTarget>functions.SubscribeToTopic</functionTarget>
</configuration>
</plugin>
<plugin>
Copy link
Contributor

@iennae iennae Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get why you would add this but I'm not sure we should be adding this to the sample code. We want to illustrate using the Google Cloud Run function with Pub/Sub with a minimal example. This feels like it's adding complexity.

Copy link
Author

@maigovannon maigovannon Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was actually needed to make mvn clean verify work properly. Without this, it fails.

<groupId>org.jacoco</groupId>
<artifactId>jacoco-maven-plugin</artifactId>
<version>0.8.11</version>
<executions>
<execution>
<goals>
<goal>prepare-agent</goal>
</goals>
</execution>
<execution>
<id>report</id>
<phase>prepare-package</phase>
<goals>
<goal>report</goal>
</goals>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
Expand Down