Skip to content
This repository was archived by the owner on Nov 11, 2022. It is now read-only.

Commit 9e27591

Browse files
committed
Response to PR comments from davorbonaci@
1 parent 0f67061 commit 9e27591

File tree

3 files changed

+2
-7
lines changed

3 files changed

+2
-7
lines changed

contrib/sorter/AUTHORS.md

Lines changed: 0 additions & 5 deletions
This file was deleted.

contrib/sorter/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
This module provides the SortValues transform, which takes a `PCollection<KV<K, Iterable<KV<K2, V>>>>` and produces a `PCollection<KV<K, Iterable<KV<K2, V>>>>` where, for each primary key `K` the paired `Iterable<KV<K2, V>>` has been sorted by the byte encoding of secondary key (`K2`). It will efficiently and scalably sort the iterables, even if they are large (do not fit in memory).
33

44
##Caveats
5-
* This transform performs value-only sorting; the iterable accompanying each key is sorted, but *there is no relationship between different keys*, as Beam does not support any defined relationship between different elements in a PCollection.
5+
* This transform performs value-only sorting; the iterable accompanying each key is sorted, but *there is no relationship between different keys*, as Dataflow does not support any defined relationship between different elements in a PCollection.
66
* Each `Iterable<KV<K2, V>>` is sorted on a single worker using local memory and disk. This means that `SortValues` may be a performance and/or scalability bottleneck when used in different pipelines. For example, users are discouraged from using `SortValues` on a `PCollection` of a single element to globally sort a large `PCollection`.
77

88
##Options

contrib/sorter/src/test/java/com/google/cloud/dataflow/contrib/sorter/SortValuesTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ public Void apply(Iterable<KV<String, Iterable<KV<String, Integer>>>> actual) {
9595
}
9696
}
9797

98-
/** Matcher for KVs. Forked from Beam's com.google.cloud.dataflow/sdk/TestUtils.java */
98+
/** Matcher for KVs. Forked from com.google.cloud.dataflow/sdk/TestUtils.java */
9999
public static class KvMatcher<K, V> extends TypeSafeMatcher<KV<? extends K, ? extends V>> {
100100
final Matcher<? super K> keyMatcher;
101101
final Matcher<? super V> valueMatcher;

0 commit comments

Comments
 (0)