Improve LateDataDroppingDoFnRunner to include reiteration.

scwhittle · scwhittle · commit 9b96b97b6eaf · 2016-12-09T12:39:49.000-08:00
diff --git a/sdk/src/test/java/com/google/cloud/dataflow/sdk/util/LateDataDroppingDoFnRunnerTest.java b/sdk/src/test/java/com/google/cloud/dataflow/sdk/util/LateDataDroppingDoFnRunnerTest.java
@@ -77,6 +77,9 @@ public void testLateDataFilter() throws Exception {
         createDatum(18, 18L));
     assertThat(expected, containsInAnyOrder(Iterables.toArray(actual, WindowedValue.class)));
     assertEquals(1, droppedDueToLateness.sum);
+    // Ensure that reiterating returns the same results and doesn't increment the counter again.
+    assertThat(expected, containsInAnyOrder(Iterables.toArray(actual, WindowedValue.class)));
+    assertEquals(1, droppedDueToLateness.sum);
   }
 
   private <T> WindowedValue<T> createDatum(T element, long timestampMillis) {
@@ -112,4 +115,3 @@ public String getName() {
     }
   }
 }
-

Original file line number	Diff line number	Diff line change
`@@ -77,6 +77,9 @@ public void testLateDataFilter() throws Exception {`
`77`	`77`	`createDatum(18, 18L));`
`78`	`78`	`assertThat(expected, containsInAnyOrder(Iterables.toArray(actual, WindowedValue.class)));`
`79`	`79`	`assertEquals(1, droppedDueToLateness.sum);`
	`80`	`+ // Ensure that reiterating returns the same results and doesn't increment the counter again.`
	`81`	`+ assertThat(expected, containsInAnyOrder(Iterables.toArray(actual, WindowedValue.class)));`
	`82`	`+ assertEquals(1, droppedDueToLateness.sum);`
`80`	`83`	`}`
`81`	`84`
`82`	`85`	`private <T> WindowedValue<T> createDatum(T element, long timestampMillis) {`
`@@ -112,4 +115,3 @@ public String getName() {`
`112`	`115`	`}`
`113`	`116`	`}`
`114`	`117`	`}`
`115`		`-`