fix: 🐛 check if a method is already hooked (#493)

* fix: 🐛 check if a method is already hooked

* fix: ✏️ fix typo

* docs: 📝 better comment

Author: KANAjetzt

addons/mod_loader/internal/mod_hook_packer.gd

@@ -50,6 +50,11 @@ static func start() -> void:
 
 		var processed_source_code := hook_pre_processor.process_script_verbose(path)
 
+		# Skip writing to the zip if no new hooks were created for this script
+		if not hook_pre_processor.script_paths_hooked.has(path):
+			ModLoaderLog.debug("No new hooks were created in \"%s\", skipping writing to hook pack." % path, LOG_NAME)
+			continue
+
 		zip_writer.start_file(path.trim_prefix("res://"))
 		zip_writer.write_file(processed_source_code.to_utf8_buffer())
 		zip_writer.close_file()

addons/mod_loader/internal/mod_hook_preprocessor.gd

@@ -33,6 +33,7 @@ var regex_keyword_await := RegEx.create_from_string("\\bawait\\b")
 
 
 var hashmap := {}
+var script_paths_hooked := {}
 
 
 func process_begin() -> void:
@@ -65,10 +66,27 @@ func process_script(path: String, enable_hook_check := false) -> String:
 		is_func_moddable.bind(source_code, getters_setters)
 	)
 
+	var methods_hooked := {}
+
 	for method in moddable_methods:
 		if method.name in method_store:
 			continue
 
+		var prefix := "%s%s_" % [METHOD_PREFIX, class_prefix]
+
+		# Check if the method name starts with the prefix added by `edit_vanilla_method()`.
+		# This indicates that the method was previously processed, possibly by the export plugin.
+		# If so, store the method name (excluding the prefix) in `methods_hooked`.
+		if method.name.begins_with(prefix):
+			var method_name_vanilla: String = method.name.trim_prefix(prefix)
+			methods_hooked[method_name_vanilla] = true
+			continue
+
+		# This ensures we avoid creating a hook for the 'imposter' method, which
+		# is generated by `build_mod_hook_string()` and has the vanilla method name.
+		if methods_hooked.has(method.name):
+			continue
+
 		var type_string := get_return_type_string(method.return)
 		var is_static := true if method.flags == METHOD_FLAG_STATIC + METHOD_FLAG_NORMAL else false
 
@@ -132,6 +150,8 @@ func process_script(path: String, enable_hook_check := false) -> String:
 		)
 		source_code_additions += "\n%s" % mod_loader_hook_string
 
+		script_paths_hooked[path] = true
+
 	# If we have some additions to the code, append them at the end
 	if source_code_additions != "":
 		source_code = "%s\n%s\n%s" % [source_code, MOD_LOADER_HOOKS_START_STRING, source_code_additions]