fix; SnapshotMut::set_value() now sets values for keys in subsections as well (#1125).

Author: Byron

gix/src/config/snapshot/access.rs

@@ -118,9 +118,13 @@ impl<'repo> SnapshotMut<'repo> {
         }
         let value = new_value.into();
         key.validate(value)?;
-        let current = self
-            .config
-            .set_raw_value(key.section().name(), None, key.name(), value)?;
+        let section = key.section();
+        let current = match section.parent() {
+            Some(parent) => self
+                .config
+                .set_raw_value(parent.name(), Some(section.name().into()), key.name(), value)?,
+            None => self.config.set_raw_value(section.name(), None, key.name(), value)?,
+        };
         Ok(current.map(std::borrow::Cow::into_owned))
     }
 

gix/tests/repository/config/config_snapshot/mod.rs

@@ -1,4 +1,4 @@
-use gix::config::tree::{Branch, Core, Key};
+use gix::config::tree::{gitoxide, Branch, Core, Key};
 
 use crate::named_repo;
 
@@ -91,6 +91,27 @@ fn values_are_set_in_memory_only() {
     assert_eq!(repo_clone.config_snapshot().string(key_subsection), None);
 }
 
+#[test]
+fn set_value_in_subsection() {
+    let mut repo = named_repo("make_config_repo.sh").unwrap();
+    {
+        let mut config = repo.config_snapshot_mut();
+        config
+            .set_value(&gitoxide::Credentials::TERMINAL_PROMPT, "yes")
+            .unwrap();
+        // TODO: this should probably be symmetric then and take a key. Figure out how non-keyed access would then be possible.
+        //       Maybe there could be different SnapshotMut types? Maybe there could be a prefix for methods for better separation?
+        //       Maybe a sub-type?
+        assert_eq!(
+            config
+                .string_by_key(&*gitoxide::Credentials::TERMINAL_PROMPT.logical_name())
+                .expect("just set")
+                .as_ref(),
+            "yes"
+        );
+    }
+}
+
 #[test]
 fn apply_cli_overrides() -> crate::Result {
     let mut repo = named_repo("make_config_repo.sh").unwrap();

gix/tests/repository/pathspec.rs

@@ -31,9 +31,9 @@ fn defaults_are_taken_from_repo_config() -> crate::Result {
         .expect("match")
         .is_excluded());
 
-    assert_eq!(
+    assert!(
         pathspec.is_included("HI", Some(false)),
-        repo.filesystem_options()?.ignore_case
+        "icase is enabled, so filesystem doesn't matter"
     );
     Ok(())
 }