Drop trailing , just before ) on same line in function calls

These appear unintentional, and in most cases may have been
introduced before rustfmt collapsed the lines, or with the idea
that they would cause rustfmt to expand the lines but where that
did not occur, or in an earlier version of the code where the last
argument was longer and thus split onto another line.

This does not remove a trailing `,` after the same argument when
the argument is on its own line. Although this does remove trailing
`,` in some macro calls (e.g., `format!`), this of course avoids
making such changes in macro definitions, where `,)` is semantic.

Author: EliahKagan

gix-attributes/tests/parse/mod.rs

@@ -117,7 +117,7 @@ fn exclamation_marks_must_be_escaped_or_error_unlike_gitignore() {
 
 #[test]
 fn invalid_escapes_in_quotes_are_an_error() {
-    assert!(matches!(try_line(r#""\!hello""#), Err(parse::Error::Unquote(_)),),);
+    assert!(matches!(try_line(r#""\!hello""#), Err(parse::Error::Unquote(_))));
     assert!(lenient_lines(r#""\!hello""#).is_empty());
 }
 

gix-config/tests/config/file/access/read_only.rs

@@ -87,7 +87,7 @@ fn get_value_for_all_provided_values() -> crate::Result {
             &[cow_str("")],
             "unset values show up as empty within a string array"
         );
-        assert_eq!(config.strings("core.bool-implicit").expect("present"), &[cow_str("")],);
+        assert_eq!(config.strings("core.bool-implicit").expect("present"), &[cow_str("")]);
 
         assert_eq!(config.string("doesn't.exist"), None);
 

gix-config/tests/config/file/init/comfort.rs

@@ -44,7 +44,7 @@ fn from_git_dir() -> crate::Result {
         "value",
         "a value from the local repo configuration"
     );
-    assert_eq!(config.string("a.local").expect("present").as_ref(), "value",);
+    assert_eq!(config.string("a.local").expect("present").as_ref(), "value");
     assert_eq!(
         config.string_by("a", None, "local-include").expect("present").as_ref(),
         "from-a.config",

gix-config/tests/config/key/mod.rs

@@ -21,7 +21,7 @@ fn valid_and_invalid() {
     assert_eq!(key.value_name, "baz");
 
     let key = r"includeIf.gitdir/i:C:\bare.git.path".as_key();
-    assert_eq!(key.subsection_name, Some(r"gitdir/i:C:\bare.git".into()),);
+    assert_eq!(key.subsection_name, Some(r"gitdir/i:C:\bare.git".into()));
 }
 
 mod _ref {

gix-config/tests/config/source/mod.rs

@@ -43,7 +43,7 @@ fn git_config_no_system() {
                 _ => unreachable!("known set"),
             }
         })
-        .is_some(),);
+        .is_some());
 }
 
 #[test]

gix-config/tests/config/value/normalize.rs

@@ -49,7 +49,7 @@ fn quotes_right_next_to_each_other() {
 #[test]
 fn escaped_quotes_are_kept() {
     let cow = normalize_bstr(r#""hello \"\" world""#);
-    assert_eq!(cow, cow_str("hello \"\" world").clone(),);
+    assert_eq!(cow, cow_str("hello \"\" world").clone());
     assert!(matches!(cow, Cow::Owned(_)));
 }
 

gix-diff/tests/diff/index.rs

@@ -312,7 +312,7 @@ fn renames_by_similarity_with_limit() -> crate::Result {
         "fuzzy tracking is effectively disabled due to limit"
     );
     let actual: Vec<_> = changes.iter().map(|c| c.fields().0).collect();
-    assert_eq!(actual, ["f1", "f1-renamed", "f2", "f2-renamed"],);
+    assert_eq!(actual, ["f1", "f1-renamed", "f2", "f2-renamed"]);
 
     let out = out.expect("tracking enabled");
     assert_eq!(out.num_similarity_checks, 0);

gix-diff/tests/diff/tree_with_rewrites.rs

@@ -422,7 +422,7 @@ fn renames_by_similarity_with_limit() -> crate::Result {
         "fuzzy tracking is effectively disabled due to limit"
     );
     let actual: Vec<_> = changes.iter().map(Change::location).collect();
-    assert_eq!(actual, ["f1", "f1-renamed", "f2", "f2-renamed"],);
+    assert_eq!(actual, ["f1", "f1-renamed", "f2", "f2-renamed"]);
 
     let out = out.expect("tracking enabled");
     assert_eq!(out.num_similarity_checks, 0);

gix-dir/tests/dir/walk.rs

@@ -2166,8 +2166,8 @@ fn untracked_and_ignored_collapse_handling_for_deletion_with_wildcards() -> crat
             entryps("c.o", Ignored(Expendable), File, WildcardMatch),
             entryps("d/a.o", Ignored(Expendable), File, WildcardMatch),
             entryps("d/b.o", Ignored(Expendable), File, WildcardMatch),
-            entryps("d/d/a.o", Ignored(Expendable), File, WildcardMatch,),
-            entryps("d/d/b.o", Ignored(Expendable), File, WildcardMatch,),
+            entryps("d/d/a.o", Ignored(Expendable), File, WildcardMatch),
+            entryps("d/d/b.o", Ignored(Expendable), File, WildcardMatch),
             entryps("generated/a.o", Ignored(Expendable), File, WildcardMatch),
             entryps("objs", Ignored(Expendable), Directory, WildcardMatch),
         ],
@@ -2213,7 +2213,7 @@ fn untracked_and_ignored_collapse_handling_for_deletion_with_wildcards() -> crat
             entryps("c.o", Ignored(Expendable), File, WildcardMatch),
             entryps("d/a.o", Ignored(Expendable), File, WildcardMatch),
             entryps("d/b.o", Ignored(Expendable), File, WildcardMatch),
-            entryps("d/d", Untracked, Directory, WildcardMatch,),
+            entryps("d/d", Untracked, Directory, WildcardMatch),
             entryps_dirstat("d/d/a.o", Ignored(Expendable), File, WildcardMatch, Untracked),
             entryps_dirstat("d/d/b.o", Ignored(Expendable), File, WildcardMatch, Untracked),
             entryps_dirstat(

gix-discover/tests/discover/upwards/mod.rs

@@ -98,7 +98,7 @@ fn from_working_dir_no_config() -> crate::Result {
     for name in ["worktree-no-config-after-init", "worktree-no-config"] {
         let dir = repo_path()?.join(name);
         let (path, trust) = gix_discover::upwards(&dir)?;
-        assert_eq!(path.kind(), Kind::WorkTree { linked_git_dir: None },);
+        assert_eq!(path.kind(), Kind::WorkTree { linked_git_dir: None });
         assert_eq!(path.as_ref(), dir, "a working tree dir yields the git dir");
         assert_eq!(trust, expected_trust());
     }