refactor: error handling

- find a way to reasonably keep previous semantics in downstream users

Author: Byron

gix-mailmap/src/lib.rs

@@ -36,6 +36,13 @@ pub mod snapshot;
 /// optionally name to find mappings to new names and/or emails.
 ///
 /// The memory layout is efficient, even though lots of small allocations are performed to store strings of emails and names.
+///
+/// ### Handling of invalid `SignatureRef::time`
+///
+/// As the `time` field in [`SignatureRef`](gix_actor::SignatureRef) as passed by the caller maybe invalid,
+/// something that should be very rare but is possible, we decided to not expose this fallibility in the API.
+/// Hence, the user may separately check for the correctness of `time`, which we replace with [`gix_date::Time::default()`]
+/// in case of parse errors.
 #[derive(Default, Clone, Debug, Eq, PartialEq)]
 pub struct Snapshot {
     /// Sorted by `old_email`

gix-mailmap/src/snapshot/mod.rs

@@ -157,17 +157,17 @@ fn enriched_signature<'a>(
         (Some(new_email), Some(new_name)) => Signature {
             email: new_email.to_owned().into(),
             name: new_name.to_owned().into(),
-            time: gix_date::Time::from_bytes(time).expect("Time must be valid"),
+            time: gix_date::Time::from_bytes(time).unwrap_or_default(),
         },
         (Some(new_email), None) => Signature {
             email: new_email.to_owned().into(),
             name: name.into(),
-            time: gix_date::Time::from_bytes(time).expect("Time must be valid"),
+            time: gix_date::Time::from_bytes(time).unwrap_or_default(),
         },
         (None, Some(new_name)) => Signature {
             email: email.into(),
             name: new_name.to_owned().into(),
-            time: gix_date::Time::from_bytes(time).expect("Time must be valid"),
+            time: gix_date::Time::from_bytes(time).unwrap_or_default(),
         },
         (None, None) => unreachable!("BUG: ResolvedSignatures don't exist here when nothing is set"),
     }

gix-mailmap/src/snapshot/signature.rs

@@ -29,7 +29,7 @@ impl<'a> From<gix_actor::SignatureRef<'a>> for Signature<'a> {
         Signature {
             name: s.name.into(),
             email: s.email.into(),
-            time: gix_date::Time::from_bytes(s.time).expect("Time must be valid"),
+            time: gix_date::Time::from_bytes(s.time).unwrap_or_default(),
         }
     }
 }