thanks clippy

With latest nightly

Author: Byron

gix-attributes/tests/parse/mod.rs

@@ -322,15 +322,15 @@ fn trailing_whitespace_in_attributes_is_ignored() {
 
 type ExpandedAttribute<'a> = (parse::Kind, Vec<(BString, gix_attributes::StateRef<'a>)>, usize);
 
-fn set(attr: &str) -> (BString, StateRef) {
+fn set(attr: &str) -> (BString, StateRef<'_>) {
     (attr.into(), StateRef::Set)
 }
 
-fn unset(attr: &str) -> (BString, StateRef) {
+fn unset(attr: &str) -> (BString, StateRef<'_>) {
     (attr.into(), StateRef::Unset)
 }
 
-fn unspecified(attr: &str) -> (BString, StateRef) {
+fn unspecified(attr: &str) -> (BString, StateRef<'_>) {
     (attr.into(), StateRef::Unspecified)
 }
 
@@ -350,36 +350,36 @@ fn pattern(name: &str, flags: gix_glob::pattern::Mode, first_wildcard_pos: Optio
     })
 }
 
-fn try_line(input: &str) -> Result<ExpandedAttribute, parse::Error> {
+fn try_line(input: &str) -> Result<ExpandedAttribute<'_>, parse::Error> {
     let mut lines = gix_attributes::parse(input.as_bytes());
     let res = expand(lines.next().unwrap())?;
     assert!(lines.next().is_none(), "expected only one line");
     Ok(res)
 }
 
-fn line(input: &str) -> ExpandedAttribute {
+fn line(input: &str) -> ExpandedAttribute<'_> {
     try_line(input).unwrap()
 }
 
-fn byte_line(input: &[u8]) -> ExpandedAttribute {
+fn byte_line(input: &[u8]) -> ExpandedAttribute<'_> {
     try_byte_line(input).unwrap()
 }
 
-fn try_byte_line(input: &[u8]) -> Result<ExpandedAttribute, parse::Error> {
+fn try_byte_line(input: &[u8]) -> Result<ExpandedAttribute<'_>, parse::Error> {
     let mut lines = gix_attributes::parse(input);
     let res = expand(lines.next().unwrap())?;
     assert!(lines.next().is_none(), "expected only one line");
     Ok(res)
 }
 
-fn lenient_lines(input: &str) -> Vec<ExpandedAttribute> {
+fn lenient_lines(input: &str) -> Vec<ExpandedAttribute<'_>> {
     gix_attributes::parse(input.as_bytes())
         .map(expand)
         .filter_map(Result::ok)
         .collect()
 }
 
-fn try_lines(input: &str) -> Result<Vec<ExpandedAttribute>, parse::Error> {
+fn try_lines(input: &str) -> Result<Vec<ExpandedAttribute<'_>>, parse::Error> {
     gix_attributes::parse(input.as_bytes()).map(expand).collect()
 }
 

gix-config/tests/config/parse/section.rs

@@ -11,7 +11,7 @@ mod header {
 
     use bstr::BStr;
 
-    fn cow_section(name: &str) -> Option<Cow<BStr>> {
+    fn cow_section(name: &str) -> Option<Cow<'_, BStr>> {
         Some(Cow::Borrowed(name.into()))
     }
     mod write_to {

gix-odb/src/store_impls/dynamic/load_index.rs

@@ -734,6 +734,7 @@ impl PartialEq<Self> for Either {
     }
 }
 
+#[allow(clippy::non_canonical_partial_ord_impl)]
 impl PartialOrd<Self> for Either {
     fn partial_cmp(&self, other: &Self) -> Option<std::cmp::Ordering> {
         Some(self.path().cmp(other.path()))

gix-ref/src/name.rs

@@ -221,6 +221,7 @@ impl<'a> convert::TryFrom<&'a str> for PartialName {
     }
 }
 
+#[allow(clippy::infallible_try_from)]
 impl<'a> convert::TryFrom<&'a FullName> for &'a PartialNameRef {
     type Error = Infallible;
 

gix-refspec/src/spec.rs

@@ -69,6 +69,7 @@ mod impls {
         }
     }
 
+    #[allow(clippy::non_canonical_partial_ord_impl)]
     impl PartialOrd for RefSpec {
         fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
             Some(self.to_ref().cmp(&other.to_ref()))

gix/tests/gix-init.rs

@@ -268,7 +268,7 @@ mod with_overrides {
         Ok(())
     }
 
-    fn cow_bstr(s: &str) -> Cow<BStr> {
+    fn cow_bstr(s: &str) -> Cow<'_, BStr> {
         Cow::Borrowed(s.into())
     }
 }

gix/tests/gix/object/tree/diff.rs

@@ -879,7 +879,7 @@ mod track_rewrites {
     }
 }
 
-fn tree_named(repo: &gix::Repository, rev_spec: impl AsRef<str>) -> gix::Tree {
+fn tree_named(repo: &gix::Repository, rev_spec: impl AsRef<str>) -> gix::Tree<'_> {
     repo.rev_parse_single(rev_spec.as_ref())
         .unwrap()
         .object()

tests/it/src/commands/blame_copy_royal.rs

@@ -161,14 +161,10 @@ git rm {src}
 "
                 ),
                 BlameScriptOperation::CommitFile(src, commit_id) => {
-                    write!(
-                        f,
-                        r"# make file {src} contain content at commit {commit_id}
-"
-                    )?;
+                    writeln!(f, r"# make file {src} contain content at commit {commit_id}")?;
                     if let Some(pos) = src.rfind_byte(b'/') {
                         let dirname = src[..pos].as_bstr();
-                        write!(f, "mkdir -p \"{dirname}\"\n")?;
+                        writeln!(f, "mkdir -p \"{dirname}\"")?;
                     }
                     write!(
                         f,