fix qodana issues

Author: arturcic

qodana.yaml

@@ -3,8 +3,6 @@
 #             https://www.jetbrains.com/help/qodana/qodana-yaml.html            #
 #-------------------------------------------------------------------------------#
 version: "1.0"
-#Specify IDE code to run analysis without container (Applied in CI/CD pipeline)
-ide: QDNET
 #Specify inspection profile for code analysis
 profile:
   name: qodana.starter

src/GitVersion.App.Tests/HelpWriterTests.cs

@@ -46,7 +46,7 @@ public void AllArgsAreInHelp()
             { nameof(Arguments.NoCache), "/nocache" },
             { nameof(Arguments.NoFetch), "/nofetch" },
             { nameof(Arguments.NoNormalize), "/nonormalize" },
-            { nameof(Arguments.AllowShallow), "/allowshallow" },
+            { nameof(Arguments.AllowShallow), "/allowshallow" }
         };
         var helpText = string.Empty;
 
@@ -55,7 +55,7 @@ public void AllArgsAreInHelp()
         var ignored = new[]
         {
             nameof(Arguments.Authentication),
-            nameof(Arguments.UpdateAssemblyInfoFileName),
+            nameof(Arguments.UpdateAssemblyInfoFileName)
         };
         typeof(Arguments).GetFields()
             .Select(p => p.Name)

src/GitVersion.App/Arguments.cs

@@ -79,7 +79,7 @@ public GitVersionOptions ToOptions()
                 NoFetch = NoFetch,
                 NoCache = NoCache,
                 NoNormalize = NoNormalize,
-                AllowShallow = AllowShallow,
+                AllowShallow = AllowShallow
             },
 
             WixInfo =

src/GitVersion.Core/Core/GitPreparer.cs

@@ -188,16 +188,14 @@ private void NormalizeGitDirectory(bool noFetch, string? currentBranchName, bool
         EnsureHeadIsAttachedToBranch(currentBranchName, authentication);
         EnsureRepositoryHeadDuringNormalisation(nameof(EnsureHeadIsAttachedToBranch), expectedSha);
 
-        if (this.repository.IsShallow)
+        if (!this.repository.IsShallow) return;
+        if (this.options.Value.Settings.AllowShallow)
         {
-            if (this.options.Value.Settings.AllowShallow)
-            {
-                this.log.Info("Repository is a shallow clone. GitVersion will continue, but it is recommended to use a full clone for accurate versioning.");
-            }
-            else
-            {
-                throw new WarningException("Repository is a shallow clone. Git repositories must contain the full history. See https://gitversion.net/docs/reference/requirements#unshallow for more info.");
-            }
+            this.log.Info("Repository is a shallow clone. GitVersion will continue, but it is recommended to use a full clone for accurate versioning.");
+        }
+        else
+        {
+            throw new WarningException("Repository is a shallow clone. Git repositories must contain the full history. See https://gitversion.net/docs/reference/requirements#unshallow for more info.");
         }
     }