(#633) Update to latest NGitLab package version

gep13 · gep13 · commit a1458d3ce72a · 2025-01-09T09:34:52.000Z
This addresses an issue which was seen when trying to close milestones
using the GitLab provider. There would be an error thrown regarding
being able to correctly serialize a number into an int32, since the
number was too big.

An upstream change was needed in NGitLab, so switch to usign to a long.
There was a similar error when using GitHub, and a bump in the version
of Octokit being used was required.

This has been tested against a GitLab repository, and the close command
which was previously failing is now working.
diff --git a/src/GitReleaseManager.Cli/GitReleaseManager.Cli.csproj b/src/GitReleaseManager.Cli/GitReleaseManager.Cli.csproj
@@ -23,6 +23,7 @@
         <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         <PrivateAssets>all</PrivateAssets>
         </PackageReference>
+        <PackageReference Include="NGitLab" Version="7.0.1" />
         <PackageReference Include="Octokit" Version="12.0.0" />
         <PackageReference Include="Serilog.Sinks.Console" Version="6.0.0" />
         <PackageReference Include="Serilog.Sinks.Debug" Version="2.0.0" PrivateAssets="All" />
diff --git a/src/GitReleaseManager.Core.Tests/GitReleaseManager.Core.Tests.csproj b/src/GitReleaseManager.Core.Tests/GitReleaseManager.Core.Tests.csproj
@@ -23,6 +23,7 @@
           <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
           <PrivateAssets>all</PrivateAssets>
         </PackageReference>
+        <PackageReference Include="NGitLab" Version="7.0.1" />
         <PackageReference Include="NSubstitute" Version="5.1.0" />
         <PackageReference Include="NUnit" Version="4.1.0" />
         <PackageReference Include="NUnit.Analyzers" Version="4.2.0">
diff --git a/src/GitReleaseManager.Core/GitReleaseManager.Core.csproj b/src/GitReleaseManager.Core/GitReleaseManager.Core.csproj
@@ -23,7 +23,7 @@
           <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
           <PrivateAssets>all</PrivateAssets>
         </PackageReference>
-        <PackageReference Include="NGitLab" Version="6.51.1" />
+        <PackageReference Include="NGitLab" Version="7.0.1" />
         <PackageReference Include="Octokit" Version="12.0.0" />
         <PackageReference Include="Scriban" Version="5.10.0" />
         <PackageReference Include="seriloganalyzer" Version="0.15.0" />
diff --git a/src/GitReleaseManager.Core/Model/Milestone.cs b/src/GitReleaseManager.Core/Model/Milestone.cs
@@ -10,7 +10,7 @@ public sealed class Milestone
 
         public int PublicNumber { get; set; }
 
-        public int InternalNumber { get; set; }
+        public long InternalNumber { get; set; }
 
         public string HtmlUrl { get; set; }
 
diff --git a/src/GitReleaseManager.Core/Provider/GitLabProvider.cs b/src/GitReleaseManager.Core/Provider/GitLabProvider.cs
@@ -34,7 +34,7 @@ public class GitLabProvider : IVcsProvider
         private readonly IMapper _mapper;
         private readonly ILogger _logger;
 
-        private int? _projectId;
+        private long? _projectId;
 
         public GitLabProvider(IGitLabClient gitLabClient, IMapper mapper, ILogger logger)
         {
@@ -391,7 +391,7 @@ public string GetIssueType(Issue issue)
             return issue.IsPullRequest ? "Merge Request" : "Issue";
         }
 
-        private int GetGitLabProjectId(string owner, string repository)
+        private long GetGitLabProjectId(string owner, string repository)
         {
             if (_projectId.HasValue)
             {
diff --git a/src/GitReleaseManager.IntegrationTests/GitReleaseManager.IntegrationTests.csproj b/src/GitReleaseManager.IntegrationTests/GitReleaseManager.IntegrationTests.csproj
@@ -21,6 +21,7 @@
           <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
           <PrivateAssets>all</PrivateAssets>
         </PackageReference>
+        <PackageReference Include="NGitLab" Version="7.0.1" />
         <PackageReference Include="NUnit" Version="4.1.0" />
         <PackageReference Include="NUnit.Analyzers" Version="4.2.0">
           <PrivateAssets>all</PrivateAssets>
diff --git a/src/GitReleaseManager.Tests/GitReleaseManager.Tests.csproj b/src/GitReleaseManager.Tests/GitReleaseManager.Tests.csproj
@@ -23,6 +23,7 @@
           <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
           <PrivateAssets>all</PrivateAssets>
         </PackageReference>
+        <PackageReference Include="NGitLab" Version="7.0.1" />
         <PackageReference Include="NSubstitute" Version="5.1.0" />
         <PackageReference Include="NUnit" Version="4.1.0" />
         <PackageReference Include="NUnit.Analyzers" Version="4.2.0">
diff --git a/src/GitReleaseManager.Tool/GitReleaseManager.Tool.csproj b/src/GitReleaseManager.Tool/GitReleaseManager.Tool.csproj
@@ -38,7 +38,7 @@
         <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         <PrivateAssets>all</PrivateAssets>
         </PackageReference>
-        <PackageReference Include="NGitLab" Version="6.51.1" />
+        <PackageReference Include="NGitLab" Version="7.0.1" />
         <PackageReference Include="Octokit" Version="12.0.0" />
         <PackageReference Include="Serilog.Sinks.Console" Version="6.0.0" />
         <PackageReference Include="Serilog.Sinks.Debug" Version="2.0.0" PrivateAssets="All" />

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ public class GitLabProvider : IVcsProvider`
`34`	`34`	`private readonly IMapper _mapper;`
`35`	`35`	`private readonly ILogger _logger;`
`36`	`36`
`37`		`- private int? _projectId;`
	`37`	`+ private long? _projectId;`
`38`	`38`
`39`	`39`	`public GitLabProvider(IGitLabClient gitLabClient, IMapper mapper, ILogger logger)`
`40`	`40`	`{`
`@@ -391,7 +391,7 @@ public string GetIssueType(Issue issue)`
`391`	`391`	`return issue.IsPullRequest ? "Merge Request" : "Issue";`
`392`	`392`	`}`
`393`	`393`
`394`		`- private int GetGitLabProjectId(string owner, string repository)`
	`394`	`+ private long GetGitLabProjectId(string owner, string repository)`
`395`	`395`	`{`
`396`	`396`	`if (_projectId.HasValue)`
`397`	`397`	`{`