refs #81: Change urlencode to rawurlencode

Author: Paolo Mainardi

lib/Gitlab/Api/AbstractApi.php

@@ -111,6 +111,6 @@ protected function delete($path, array $parameters = array(), $requestHeaders =
      */
     protected function getProjectPath($id, $path)
     {
-        return 'projects/'.urlencode($id).'/'.$path;
+        return 'projects/'.rawurlencode($id).'/'.$path;
     }
 }

lib/Gitlab/Api/Groups.php

@@ -23,7 +23,7 @@ public function all($page = 1, $per_page = self::PER_PAGE)
      */
     public function search($query, $page = 1, $per_page = self::PER_PAGE)
     {
-        return $this->get('groups?search='.urlencode($query), array(
+        return $this->get('groups?search='.rawurlencode($query), array(
             'page' => $page,
             'per_page' => $per_page
         ));
@@ -35,7 +35,7 @@ public function search($query, $page = 1, $per_page = self::PER_PAGE)
      */
     public function show($id)
     {
-        return $this->get('groups/'.urlencode($id));
+        return $this->get('groups/'.rawurlencode($id));
     }
 
     /**
@@ -59,7 +59,7 @@ public function create($name, $path, $description = null)
      */
     public function remove($group_id)
     {
-        return $this->delete('groups/'.urlencode($group_id));
+        return $this->delete('groups/'.rawurlencode($group_id));
     }
 
     /**
@@ -69,7 +69,7 @@ public function remove($group_id)
      */
     public function transfer($group_id, $project_id)
     {
-        return $this->post('groups/'.urlencode($group_id).'/projects/'.urlencode($project_id));
+        return $this->post('groups/'.rawurlencode($group_id).'/projects/'.rawurlencode($project_id));
     }
 
     /**
@@ -80,7 +80,7 @@ public function transfer($group_id, $project_id)
      */
     public function members($id, $page = 1, $per_page = self::PER_PAGE)
     {
-        return $this->get('groups/'.urlencode($id).'/members', array(
+        return $this->get('groups/'.rawurlencode($id).'/members', array(
             'page' => $page,
             'per_page' => $per_page
         ));
@@ -94,7 +94,7 @@ public function members($id, $page = 1, $per_page = self::PER_PAGE)
      */
     public function addMember($group_id, $user_id, $access_level)
     {
-        return $this->post('groups/'.urlencode($group_id).'/members', array(
+        return $this->post('groups/'.rawurlencode($group_id).'/members', array(
             'user_id' => $user_id,
             'access_level' => $access_level
         ));
@@ -108,7 +108,7 @@ public function addMember($group_id, $user_id, $access_level)
      */
     public function saveMember($group_id, $user_id, $access_level)
     {
-        return $this->put('groups/'.urlencode($group_id).'/members/'.urlencode($user_id), array(
+        return $this->put('groups/'.rawurlencode($group_id).'/members/'.rawurlencode($user_id), array(
             'access_level' => $access_level
         ));
     }
@@ -120,6 +120,6 @@ public function saveMember($group_id, $user_id, $access_level)
      */
     public function removeMember($group_id, $user_id)
     {
-        return $this->delete('groups/'.urlencode($group_id).'/members/'.urlencode($user_id));
+        return $this->delete('groups/'.rawurlencode($group_id).'/members/'.rawurlencode($user_id));
     }
 }

lib/Gitlab/Api/Issues.php

@@ -29,7 +29,7 @@ public function all($project_id = null, $page = 1, $per_page = self::PER_PAGE, a
      */
     public function show($project_id, $issue_id)
     {
-        return $this->get($this->getProjectPath($project_id, 'issues/'.urlencode($issue_id)));
+        return $this->get($this->getProjectPath($project_id, 'issues/'.rawurlencode($issue_id)));
     }
 
     /**
@@ -50,7 +50,7 @@ public function create($project_id, array $params)
      */
     public function update($project_id, $issue_id, array $params)
     {
-        return $this->put($this->getProjectPath($project_id, 'issues/'.urlencode($issue_id)), $params);
+        return $this->put($this->getProjectPath($project_id, 'issues/'.rawurlencode($issue_id)), $params);
     }
 
     /**
@@ -60,7 +60,7 @@ public function update($project_id, $issue_id, array $params)
      */
     public function showComments($project_id, $issue_id)
     {
-        return $this->get($this->getProjectPath($project_id, 'issues/'.urlencode($issue_id)).'/notes');
+        return $this->get($this->getProjectPath($project_id, 'issues/'.rawurlencode($issue_id)).'/notes');
     }
 
     /**
@@ -71,7 +71,7 @@ public function showComments($project_id, $issue_id)
      */
     public function showComment($project_id, $issue_id, $note_id)
     {
-        return $this->get($this->getProjectPath($project_id, 'issues/'.urlencode($issue_id)).'/notes/'.urlencode($note_id));
+        return $this->get($this->getProjectPath($project_id, 'issues/'.rawurlencode($issue_id)).'/notes/'.rawurlencode($note_id));
     }
 
     /**
@@ -89,7 +89,7 @@ public function addComment($project_id, $issue_id, $body)
             $params = array('body' => $body);
         }
 
-        return $this->post($this->getProjectPath($project_id, 'issues/'.urlencode($issue_id).'/notes'), $params);
+        return $this->post($this->getProjectPath($project_id, 'issues/'.rawurlencode($issue_id).'/notes'), $params);
     }
 
     /**
@@ -101,7 +101,7 @@ public function addComment($project_id, $issue_id, $body)
      */
     public function updateComment($project_id, $issue_id, $note_id, $body)
     {
-        return $this->put($this->getProjectPath($project_id, 'issues/'.urlencode($issue_id).'/notes/'.urlencode($note_id)), array(
+        return $this->put($this->getProjectPath($project_id, 'issues/'.rawurlencode($issue_id).'/notes/'.rawurlencode($note_id)), array(
             'body' => $body
         ));
     }

lib/Gitlab/Api/MergeRequests.php

@@ -89,7 +89,7 @@ public function closed($project_id, $page = 1, $per_page = self::PER_PAGE, $orde
      */
     public function show($project_id, $mr_id)
     {
-        return $this->get($this->getProjectPath($project_id, 'merge_request/'.urlencode($mr_id)));
+        return $this->get($this->getProjectPath($project_id, 'merge_request/'.rawurlencode($mr_id)));
     }
 
     /**
@@ -122,7 +122,7 @@ public function create($project_id, $source, $target, $title, $assignee = null,
      */
     public function update($project_id, $mr_id, array $params)
     {
-        return $this->put($this->getProjectPath($project_id, 'merge_request/'.urlencode($mr_id)), $params);
+        return $this->put($this->getProjectPath($project_id, 'merge_request/'.rawurlencode($mr_id)), $params);
     }
 
     /**
@@ -139,7 +139,7 @@ public function merge($project_id, $mr_id, $message = null)
             $params = array('merge_commit_message' => $message);
         }
 
-        return $this->put($this->getProjectPath($project_id, 'merge_request/'.urlencode($mr_id).'/merge'), $params);
+        return $this->put($this->getProjectPath($project_id, 'merge_request/'.rawurlencode($mr_id).'/merge'), $params);
     }
 
     /**
@@ -149,7 +149,7 @@ public function merge($project_id, $mr_id, $message = null)
      */
     public function showComments($project_id, $mr_id)
     {
-        return $this->get($this->getProjectPath($project_id, 'merge_request/'.urlencode($mr_id).'/comments'));
+        return $this->get($this->getProjectPath($project_id, 'merge_request/'.rawurlencode($mr_id).'/comments'));
     }
 
     /**
@@ -160,7 +160,7 @@ public function showComments($project_id, $mr_id)
      */
     public function addComment($project_id, $mr_id, $note)
     {
-        return $this->post($this->getProjectPath($project_id, 'merge_request/'.urlencode($mr_id).'/comments'), array(
+        return $this->post($this->getProjectPath($project_id, 'merge_request/'.rawurlencode($mr_id).'/comments'), array(
             'note' => $note
         ));
     }
@@ -172,6 +172,6 @@ public function addComment($project_id, $mr_id, $note)
      */
     public function changes($project_id, $mr_id)
     {
-        return $this->get($this->getProjectPath($project_id, 'merge_request/'.urlencode($mr_id).'/changes'));
+        return $this->get($this->getProjectPath($project_id, 'merge_request/'.rawurlencode($mr_id).'/changes'));
     }
 }

lib/Gitlab/Api/Milestones.php

@@ -23,7 +23,7 @@ public function all($project_id, $page = 1, $per_page = self::PER_PAGE)
      */
     public function show($project_id, $milestone_id)
     {
-        return $this->get($this->getProjectPath($project_id, 'milestones/'.urlencode($milestone_id)));
+        return $this->get($this->getProjectPath($project_id, 'milestones/'.rawurlencode($milestone_id)));
     }
 
     /**
@@ -44,7 +44,7 @@ public function create($project_id, array $params)
      */
     public function update($project_id, $milestone_id, array $params)
     {
-        return $this->put($this->getProjectPath($project_id, 'milestones/'.urlencode($milestone_id)), $params);
+        return $this->put($this->getProjectPath($project_id, 'milestones/'.rawurlencode($milestone_id)), $params);
     }
 
     /**
@@ -54,6 +54,6 @@ public function update($project_id, $milestone_id, array $params)
      */
     public function issues($project_id, $milestone_id)
     {
-        return $this->get($this->getProjectPath($project_id, 'milestones/'.urlencode($milestone_id).'/issues'));
+        return $this->get($this->getProjectPath($project_id, 'milestones/'.rawurlencode($milestone_id).'/issues'));
     }
 }

lib/Gitlab/Api/Repositories.php

@@ -18,7 +18,7 @@ public function branches($project_id)
      */
     public function branch($project_id, $branch_id)
     {
-        return $this->get($this->getProjectPath($project_id, 'repository/branches/'.urlencode($branch_id)));
+        return $this->get($this->getProjectPath($project_id, 'repository/branches/'.rawurlencode($branch_id)));
     }
 
     /**
@@ -42,7 +42,7 @@ public function createBranch($project_id, $branch_name, $ref)
      */
     public function deleteBranch($project_id, $branch_name)
     {
-        return $this->delete($this->getProjectPath($project_id, 'repository/branches/'.urlencode($branch_name)));
+        return $this->delete($this->getProjectPath($project_id, 'repository/branches/'.rawurlencode($branch_name)));
     }
 
     /**
@@ -52,7 +52,7 @@ public function deleteBranch($project_id, $branch_name)
      */
     public function protectBranch($project_id, $branch_name)
     {
-        return $this->put($this->getProjectPath($project_id, 'repository/branches/'.urlencode($branch_name).'/protect'));
+        return $this->put($this->getProjectPath($project_id, 'repository/branches/'.rawurlencode($branch_name).'/protect'));
     }
 
     /**
@@ -62,7 +62,7 @@ public function protectBranch($project_id, $branch_name)
      */
     public function unprotectBranch($project_id, $branch_name)
     {
-        return $this->put($this->getProjectPath($project_id, 'repository/branches/'.urlencode($branch_name).'/unprotect'));
+        return $this->put($this->getProjectPath($project_id, 'repository/branches/'.rawurlencode($branch_name).'/unprotect'));
     }
 
     /**
@@ -113,7 +113,7 @@ public function commits($project_id, $page = 0, $per_page = self::PER_PAGE, $ref
      */
     public function commit($project_id, $sha)
     {
-        return $this->get($this->getProjectPath($project_id, 'repository/commits/'.urlencode($sha)));
+        return $this->get($this->getProjectPath($project_id, 'repository/commits/'.rawurlencode($sha)));
     }
 
     /**
@@ -125,7 +125,7 @@ public function commit($project_id, $sha)
      */
     public function commitComments($project_id, $sha, $page = 0, $per_page = self::PER_PAGE)
     {
-        return $this->get($this->getProjectPath($project_id, 'repository/commits/'.urlencode($sha).'/comments'), array(
+        return $this->get($this->getProjectPath($project_id, 'repository/commits/'.rawurlencode($sha).'/comments'), array(
             'page' => $page,
             'per_page' => $per_page
         ));
@@ -142,7 +142,7 @@ public function createCommitComment($project_id, $sha, $note, array $params = ar
     {
         $params['note'] = $note;
 
-        return $this->post($this->getProjectPath($project_id, 'repository/commits/'.urlencode($sha).'/comments'), $params);
+        return $this->post($this->getProjectPath($project_id, 'repository/commits/'.rawurlencode($sha).'/comments'), $params);
     }
 
     /**
@@ -155,7 +155,7 @@ public function compare($project_id, $fromShaOrMaster, $toShaOrMaster)
     {
         return $this->get($this->getProjectPath(
             $project_id,
-            'repository/compare?from='.urlencode($fromShaOrMaster).'&to='.urlencode($toShaOrMaster)
+            'repository/compare?from='.rawurlencode($fromShaOrMaster).'&to='.rawurlencode($toShaOrMaster)
         ));
     }
 
@@ -166,7 +166,7 @@ public function compare($project_id, $fromShaOrMaster, $toShaOrMaster)
      */
     public function diff($project_id, $sha)
     {
-        return $this->get($this->getProjectPath($project_id, 'repository/commits/'.urlencode($sha).'/diff'));
+        return $this->get($this->getProjectPath($project_id, 'repository/commits/'.rawurlencode($sha).'/diff'));
     }
 
     /**
@@ -187,7 +187,7 @@ public function tree($project_id, array $params = array())
      */
     public function blob($project_id, $sha, $filepath)
     {
-        return $this->get($this->getProjectPath($project_id, 'repository/commits/'.urlencode($sha).'/blob'), array(
+        return $this->get($this->getProjectPath($project_id, 'repository/commits/'.rawurlencode($sha).'/blob'), array(
             'filepath' => $filepath
         ));
     }

lib/Gitlab/Api/Snippets.php

@@ -18,7 +18,7 @@ public function all($project_id)
      */
     public function show($project_id, $snippet_id)
     {
-        return $this->get($this->getProjectPath($project_id, 'snippets/'.urlencode($snippet_id)));
+        return $this->get($this->getProjectPath($project_id, 'snippets/'.rawurlencode($snippet_id)));
     }
 
     /**
@@ -45,7 +45,7 @@ public function create($project_id, $title, $filename, $code)
      */
     public function update($project_id, $snippet_id, array $params)
     {
-        return $this->put($this->getProjectPath($project_id, 'snippets/'.urlencode($snippet_id)), $params);
+        return $this->put($this->getProjectPath($project_id, 'snippets/'.rawurlencode($snippet_id)), $params);
     }
 
     /**
@@ -55,7 +55,7 @@ public function update($project_id, $snippet_id, array $params)
      */
     public function content($project_id, $snippet_id)
     {
-        return $this->get($this->getProjectPath($project_id, 'snippets/'.urlencode($snippet_id).'/raw'));
+        return $this->get($this->getProjectPath($project_id, 'snippets/'.rawurlencode($snippet_id).'/raw'));
     }
 
     /**
@@ -65,6 +65,6 @@ public function content($project_id, $snippet_id)
      */
     public function remove($project_id, $snippet_id)
     {
-        return $this->delete($this->getProjectPath($project_id, 'snippets/'.urlencode($snippet_id)));
+        return $this->delete($this->getProjectPath($project_id, 'snippets/'.rawurlencode($snippet_id)));
     }
 }

lib/Gitlab/Api/SystemHooks.php

@@ -27,7 +27,7 @@ public function create($url)
      */
     public function test($id)
     {
-        return $this->get('hooks/'.urlencode($id));
+        return $this->get('hooks/'.rawurlencode($id));
     }
 
     /**
@@ -36,6 +36,6 @@ public function test($id)
      */
     public function remove($id)
     {
-        return $this->delete('hooks/'.urlencode($id));
+        return $this->delete('hooks/'.rawurlencode($id));
     }
 }