switch from the now deprecated to the new status page (#2547)

* switch from the now deprecated to the new statuspage

the "old" status page https://status.github.com is no deprecated and
GitHub switched to a statuspage.io implementation with
https://githubstatus.com. The page mentions the deprecation.

This PR switches the url to the new status page and changes the status
API model for the new REST-response.

The new API replaced the `good` state with the state `none`. And has more
fields, that are probably not relevant for the App.

* Only set the status' text once

* Introduce a dark red for the critical API status

* Add a space

* Add "www."-prefix to prevent redirects

Author: romankl

Classes/Settings/SettingsViewController.swift

@@ -84,18 +84,13 @@ GitHubSessionListener {
                 strongSelf.apiStatusView.isHidden = true
                 strongSelf.apiStatusLabel.text = NSLocalizedString("error", comment: "")
             case .success(let response):
-                let text: String
+                let text = response.data.status.description
                 let color: UIColor
-                switch response.data.status {
-                case .good:
-                    text = NSLocalizedString("Good", comment: "")
-                    color = Styles.Colors.Green.medium.color
-                case .minor:
-                    text = NSLocalizedString("Minor", comment: "")
-                    color = Styles.Colors.Yellow.medium.color
-                case .major:
-                    text = NSLocalizedString("Major", comment: "")
-                    color = Styles.Colors.Red.medium.color
+                switch response.data.status.indicator {
+                case .none: color = Styles.Colors.Green.medium.color
+                case .minor: color = Styles.Colors.Yellow.medium.color
+                case .major: color = Styles.Colors.Red.medium.color
+                case .critical: color = Styles.Colors.Red.dark.color
                 }
                 strongSelf.apiStatusView.isHidden = false
                 strongSelf.apiStatusView.backgroundColor = color
@@ -146,7 +141,7 @@ GitHubSessionListener {
     }
 
     private func onGitHubStatus() {
-        guard let url = URLBuilder(host: "status.github.com").add(path: "messages").url
+        guard let url = URLBuilder(host: "www.githubstatus.com").url
             else { return }
         presentSafari(url: url)
     }

Classes/Views/Styles.swift

@@ -91,6 +91,7 @@ enum Styles {
         static let splitViewBackground = UIColor(red: 0.556863, green: 0.556863, blue: 0.576471, alpha: 1)
 
         enum Red {
+            static let dark = "75151d"
             static let medium = "cb2431"
             static let light = "ffeef0"
         }

Local Pods/GitHubAPI/GitHubAPI/GitHubAPIStatusRequest.swift

@@ -9,15 +9,22 @@
 import Foundation
 
 public struct APIStatus: Codable {
-    public enum StatusType: String, Codable {
-        case good, minor, major
+    public let status: Status
+}
+
+public struct Status: Codable {
+    public let indicator: StatusType
+    public let description: String
+    
+    public enum StatusType: String, Codable, CodingKey {
+        case none, minor, major, critical
     }
-    public let status: StatusType
 }
 
+
 public struct GitHubAPIStatusRequest: HTTPRequest {
     public typealias ResponseType = V3DataResponse<APIStatus>
-    public var url: String { return "https://status.github.com/api/status.json" }
+    public var url: String { return "https://www.githubstatus.com/api/v2/status.json" }
     public var logoutOnAuthFailure: Bool { return false }
     public var method: HTTPMethod { return .get }
     public var parameters: [String : Any]? { return nil }