Migrate to Xcode 10.2.x (#2733)

* Update Apollo dependency to 0.10.0; use Apollo CLI to generate API; audit & fix npm package

* Adapt new Apollo GraphQL build phase

* Adapt new API nodes structure

* Disable unused_setter_value swiftlint rule (issue SwiftLint#2585)

* Apply conformance to revamped Hashable protocol

* Apply Xcode's recommended settings

* Amend  issue attribute name

* Extract Apollo GQL API generation build phase to script

* Extract API keys validation build phase to script

* Update Apollo to latest version & fix Podfile warnings

Author: viktorasl

.swiftlint.yml

@@ -11,6 +11,7 @@ disabled_rules:
   - file_length
   - large_tuple
   - nesting
+  - unused_setter_value
 
 included: 
   - Classes

Classes/Issues/Comments/Reactions/IssueCommentReactionViewModel.swift

@@ -9,12 +9,6 @@
 import Foundation
 import IGListKit
 
-extension ReactionContent: Hashable {
-    public var hashValue: Int {
-        return rawValue.hashValue
-    }
-}
-
 final class IssueCommentReactionViewModel: ListDiffable {
 
     let models: [ReactionViewModel]

Classes/Issues/GithubClient+Issues.swift

@@ -154,7 +154,7 @@ extension GithubClient {
                         title: titleStringSizing(title: issueType.title, contentSizeCategory: contentSizeCategory, width: width),
                         labels: IssueLabelsModel(
                             status: IssueLabelStatusModel(status: status, pullRequest: issueType.pullRequest),
-                            locked: issueType.locked,
+                            locked: issueType.isLocked,
                             labels: issueType.labelableFields.issueLabelModels
                         ),
                         assignee: createAssigneeModel(assigneeFields: issueType.assigneeFields),

Classes/Issues/Issue+IssueType.swift

@@ -11,6 +11,18 @@ import IGListKit
 
 extension IssueOrPullRequestQuery.Data.Repository.IssueOrPullRequest.AsIssue: IssueType {
 
+    var id: String {
+        return fragments.nodeFields.id
+    }
+
+    var isLocked: Bool {
+        return fragments.lockableFields.locked
+    }
+
+    var viewerCanUpdate: Bool {
+        return fragments.updatableFields.viewerCanUpdate
+    }
+
     var pullRequest: Bool {
         return false
     }

Classes/Issues/IssueType.swift

@@ -30,7 +30,7 @@ protocol IssueType {
     var milestoneFields: MilestoneFields? { get }
     var merged: Bool { get }
     var targetBranch: String? { get }
-    var locked: Bool { get }
+    var isLocked: Bool { get }
     var headPaging: HeadPaging { get }
     var viewerCanUpdate: Bool { get }
     var fileChanges: FileChanges? { get }

Classes/Issues/PullRequest+IssueType.swift

@@ -12,6 +12,18 @@ import StyledTextKit
 
 extension IssueOrPullRequestQuery.Data.Repository.IssueOrPullRequest.AsPullRequest: IssueType {
 
+    var id: String {
+        return fragments.nodeFields.id
+    }
+
+    var isLocked: Bool {
+        return fragments.lockableFields.locked
+    }
+
+    var viewerCanUpdate: Bool {
+        return fragments.updatableFields.viewerCanUpdate
+    }
+
     var pullRequest: Bool {
         return true
     }
@@ -57,7 +69,7 @@ extension IssueOrPullRequestQuery.Data.Repository.IssueOrPullRequest.AsPullReque
             else { return nil }
 
         var contexts = [IssueMergeContextModel]()
-        for context in commit.status?.contexts ?? [] {
+        for context in commit.fragments.commitContext.status?.contexts ?? [] {
             guard let creator = context.creator,
                 let avatarURL = URL(string: creator.avatarUrl),
                 let targetUrlString = context.targetUrl,
@@ -75,7 +87,7 @@ extension IssueOrPullRequestQuery.Data.Repository.IssueOrPullRequest.AsPullReque
         }
 
         return IssueMergeModel(
-            id: commit.id,
+            id: commit.fragments.commitContext.id,
             state: mergeStateStatus,
             contexts: contexts,
             availableTypes: availableTypes

Classes/Models/RepositoryLabel.swift

@@ -33,9 +33,9 @@ final class RepositoryLabel: ListDiffable, Hashable, Equatable, ListSwiftDiffabl
 
     // MARK: Hashable
 
-    var hashValue: Int {
-        return color.hashValue
-            .combineHash(with: name.hashValue)
+    public func hash(into hasher: inout Hasher) {
+        hasher.combine(color.hashValue)
+        hasher.combine(name.hashValue)
     }
 
     // MARK: Equatable

Classes/Repository/GQL+RepositoryIssueSummaryType.swift

@@ -10,6 +10,10 @@ import Foundation
 
 extension RepoSearchPagesQuery.Data.Search.Node.AsIssue: RepositoryIssueSummaryType {
 
+    var id: String {
+        return fragments.nodeFields.id
+    }
+
     var labelableFields: LabelableFields {
         return fragments.labelableFields
     }
@@ -37,6 +41,10 @@ extension RepoSearchPagesQuery.Data.Search.Node.AsIssue: RepositoryIssueSummaryT
 
 extension RepoSearchPagesQuery.Data.Search.Node.AsPullRequest: RepositoryIssueSummaryType {
 
+    var id: String {
+        return fragments.nodeFields.id
+    }
+
     var labelableFields: LabelableFields {
         return fragments.labelableFields
     }

Freetime.xcodeproj/project.pbxproj

@@ -2488,7 +2488,7 @@
 			isa = PBXProject;
 			attributes = {
 				LastSwiftUpdateCheck = 0930;
-				LastUpgradeCheck = 1000;
+				LastUpgradeCheck = 1020;
 				ORGANIZATIONNAME = "Ryan Nystrom";
 				TargetAttributes = {
 					294EE4B8209006BF002C9CB1 = {
@@ -2539,7 +2539,7 @@
 			};
 			buildConfigurationList = 297AE82F1EC0D58A00B44A1F /* Build configuration list for PBXProject "Freetime" */;
 			compatibilityVersion = "Xcode 3.2";
-			developmentRegion = English;
+			developmentRegion = en;
 			hasScannedForEncodings = 0;
 			knownRegions = (
 				en,
@@ -2618,7 +2618,7 @@
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 			shellPath = /bin/sh;
-			shellScript = "if [[ ! -z \"${DISABLE_APOLLO}\" ]]; then\n  echo \"Stopping Task: Remove 'DISABLE_APOLLO' env variable to continue.\"\n  exit\nfi\n\nPATH=\"$(npm bin):$PATH\"\n\nAPOLLO_FRAMEWORK_PATH=\"$(eval find $FRAMEWORK_SEARCH_PATHS -name \\\"Apollo.framework\\\" -maxdepth 1)\"\n\nif [ -z \"$APOLLO_FRAMEWORK_PATH\" ]; then\necho \"error: Couldn't find Apollo.framework in FRAMEWORK_SEARCH_PATHS; make sure to add the framework to your project.\"\nexit 1\nfi\n\ncd \"${SRCROOT}/gql\"\nTEMP_FILE=$(mktemp)\n\n[[ -f API.swift ]] || touch API.swift # ensure sure file exists\n\n$APOLLO_FRAMEWORK_PATH/check-and-run-apollo-codegen.sh generate $(find . -name '*.graphql') --schema schema.json --output $TEMP_FILE\n\ncmp API.swift $TEMP_FILE || cp $TEMP_FILE API.swift";
+			shellScript = "./build-phases/generate-apollo-graphql-api.sh\n";
 		};
 		295B51391FC2342200C3993B /* Run Fabric */ = {
 			isa = PBXShellScriptBuildPhase;
@@ -2700,7 +2700,7 @@
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 			shellPath = /bin/sh;
-			shellScript = "FAILED=false\n\nif [ -z \"${BUDDYBUILD_BUILD_NUMBER}\" ]; then\n  echo \"Script is not being run on CI\"\n  exit 0\nfi\n\nif [ -z \"${GITHUB_CLIENT_ID}\" ]; then\n  echo \"${SRCROOT}/Classes/Systems/Secrets.swift:14:1: warning: Missing GitHub Client ID\"\n  FAILED=true\nfi\n\nif [ -z \"${GITHUB_CLIENT_SECRET}\" ]; then\n  echo \"${SRCROOT}/Classes/Systems/Secrets.swift:15:1: warning: Missing GitHub Client Secret\"\n  FAILED=true\nfi\n\nif [ -z \"${IMGUR_CLIENT_ID}\" ]; then\n  echo \"${SRCROOT}/Classes/Systems/Secrets.swift:16:1: warning: Missing Imgur Client ID\"\n  FAILED=true\nfi\n\nsed -i \".tmp\" \"s|{GITHUBID}|${GITHUB_CLIENT_ID}|g; s|{GITHUBSECRET}|${GITHUB_CLIENT_SECRET}|g; s|{IMGURID}|${IMGUR_CLIENT_ID}|g\" \"${SRCROOT}/Classes/Systems/Secrets.swift\"\n\nif [ \"$FAILED\" = true ]; then\n  exit 1\nfi\n\necho \"All env values found!\"";
+			shellScript = "./build-phases/validate-api-keys.sh\n";
 		};
 		ABA015066A84600AF351C942 /* [CP] Embed Pods Frameworks */ = {
 			isa = PBXShellScriptBuildPhase;
@@ -3653,6 +3653,7 @@
 			isa = XCBuildConfiguration;
 			buildSettings = {
 				ALWAYS_SEARCH_USER_PATHS = NO;
+				CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
 				CLANG_ANALYZER_NONNULL = YES;
 				CLANG_ANALYZER_NUMBER_OBJECT_CONVERSION = YES_AGGRESSIVE;
 				CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
@@ -3714,6 +3715,7 @@
 			isa = XCBuildConfiguration;
 			buildSettings = {
 				ALWAYS_SEARCH_USER_PATHS = NO;
+				CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
 				CLANG_ANALYZER_NONNULL = YES;
 				CLANG_ANALYZER_NUMBER_OBJECT_CONVERSION = YES_AGGRESSIVE;
 				CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
@@ -3886,6 +3888,7 @@
 			isa = XCBuildConfiguration;
 			buildSettings = {
 				ALWAYS_SEARCH_USER_PATHS = NO;
+				CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
 				CLANG_ANALYZER_NONNULL = YES;
 				CLANG_ANALYZER_NUMBER_OBJECT_CONVERSION = YES_AGGRESSIVE;
 				CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";

Freetime.xcodeproj/xcshareddata/xcschemes/Freetime-AppCenter.xcscheme

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1000"
+   LastUpgradeVersion = "1020"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"