Skip to content
This repository was archived by the owner on Sep 20, 2023. It is now read-only.

Commit 424b6c4

Browse files
wayni208BasThomas
authored andcommitted
Fix for "Accessibility “bullets hollow” should be “more options” #2673 (#2683)
* Fix for "Accessibility “bullets hollow” should be “more options” #2673 Changed all occurrences of "bullets-hollow" to "chevron-down" to be consistent with the "More Options" button image used in MergeButton.swift * Revert "Fix for "Accessibility “bullets hollow” should be “more options” #2673" This reverts commit d50c4ff. * Fix for "Accessibility “bullets hollow” should be “more options” #2673 Added accessibilityLabel and set to moreOptions. * Fix double spaces
1 parent c955899 commit 424b6c4

File tree

3 files changed

+3
-0
lines changed

3 files changed

+3
-0
lines changed

Classes/Repository/RepositoryCodeBlobViewController.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ final class RepositoryCodeBlobViewController: UIViewController, EmptyViewDelegat
3030
target: self,
3131
action: #selector(RepositoryCodeBlobViewController.onShare(sender:))
3232
)
33+
barButtonItem.accessibilityLabel = Constants.Strings.moreOptions
3334
return barButtonItem
3435
}()
3536

Classes/Repository/RepositoryCodeDirectoryViewController.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ IndicatorInfoProvider {
3535
image: UIImage(named: "bullets-hollow"),
3636
target: self,
3737
action: #selector(RepositoryCodeDirectoryViewController.onShare(sender:)))
38+
barButtonItem.accessibilityLabel = Constants.Strings.moreOptions
3839
barButtonItem.isEnabled = false
3940
return barButtonItem
4041
}()

Classes/Repository/RepositoryImageViewController.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ UIScrollViewDelegate {
3838
image: UIImage(named: "bullets-hollow"),
3939
target: self,
4040
action: #selector(RepositoryImageViewController.onShare(sender:)))
41+
barButtonItem.accessibilityLabel = Constants.Strings.moreOptions
4142
barButtonItem.isEnabled = false
4243
return barButtonItem
4344
}()

0 commit comments

Comments
 (0)