refactor: change Incident to better reflect vault conditions

Author: kash-jay

src/lib/api-types.ts

@@ -16,20 +16,25 @@ export type Validity =
   | "invalid"
   | "valid";
 
-export interface Incident {
+type IncidentVaultProperties = {
+  secret_vaulted: false;
+} | {
+  secret_vaulted: true;
+  vault_type: string;
+  vault_name: string;
+  vault_path: string;
+  vault_path_count: number;
+}
+
+export type Incident = {
   type: string;
   occurrences: Occurrence[];
   validity: Validity;
   ignore_sha: string;
   known_secret: boolean;
   incident_url: string;
   total_occurrences: number;
-  secret_vaulted: boolean;
-  vault_type: string;
-  vault_name: string;
-  vault_path: string;
-  vault_path_count: number;
-}
+} & IncidentVaultProperties
 
 export interface EntityWithIncidents {
   incidents: Incident[];