ext: Cleanup some dead assignments

weltling · weltling · commit 56c16334e5d2 · 2021-05-29T13:03:32.000+02:00
Signed-off-by: Anatol Belski &lt;ab@php.net&gt;
diff --git a/ext/opcache/zend_persist_calc.c b/ext/opcache/zend_persist_calc.c
@@ -246,7 +246,6 @@ static void zend_persist_op_array_calc_ex(zend_op_array *op_array)
 		uint32_t num_args = op_array->num_args;
 		uint32_t i;
 
-		num_args = op_array->num_args;
 		if (op_array->fn_flags & ZEND_ACC_VARIADIC) {
 			num_args++;
 		}
diff --git a/ext/spl/spl_iterators.c b/ext/spl/spl_iterators.c
@@ -1779,7 +1779,7 @@ PHP_METHOD(RegexIterator, __construct)
 /* {{{ Calls the callback with the current value, the current key and the inner iterator as arguments */
 PHP_METHOD(CallbackFilterIterator, accept)
 {
-	spl_dual_it_object *intern = Z_SPLDUAL_IT_P(ZEND_THIS);
+	spl_dual_it_object *intern;
 
 	if (zend_parse_parameters_none() == FAILURE) {
 		RETURN_THROWS();
diff --git a/ext/standard/user_filters.c b/ext/standard/user_filters.c
@@ -209,7 +209,7 @@ php_stream_filter_status_t userfilter_filter(
 	}
 
 	if (buckets_in->head) {
-		php_stream_bucket *bucket = buckets_in->head;
+		php_stream_bucket *bucket;
 
 		php_error_docref(NULL, E_WARNING, "Unprocessed filter buckets remaining on input brigade");
 		while ((bucket = buckets_in->head)) {

Original file line number	Diff line number	Diff line change
`@@ -246,7 +246,6 @@ static void zend_persist_op_array_calc_ex(zend_op_array *op_array)`
`246`	`246`	`uint32_t num_args = op_array->num_args;`
`247`	`247`	`uint32_t i;`
`248`	`248`
`249`		`- num_args = op_array->num_args;`
`250`	`249`	`if (op_array->fn_flags & ZEND_ACC_VARIADIC) {`
`251`	`250`	`num_args++;`
`252`	`251`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1779,7 +1779,7 @@ PHP_METHOD(RegexIterator, __construct)`
`1779`	`1779`	`/* {{{ Calls the callback with the current value, the current key and the inner iterator as arguments */`
`1780`	`1780`	`PHP_METHOD(CallbackFilterIterator, accept)`
`1781`	`1781`	`{`
`1782`		`- spl_dual_it_object *intern = Z_SPLDUAL_IT_P(ZEND_THIS);`
	`1782`	`+ spl_dual_it_object *intern;`
`1783`	`1783`
`1784`	`1784`	`if (zend_parse_parameters_none() == FAILURE) {`
`1785`	`1785`	`RETURN_THROWS();`
Original file line number	Diff line number	Diff line change
`@@ -209,7 +209,7 @@ php_stream_filter_status_t userfilter_filter(`
`209`	`209`	`}`
`210`	`210`
`211`	`211`	`if (buckets_in->head) {`
`212`		`- php_stream_bucket *bucket = buckets_in->head;`
	`212`	`+ php_stream_bucket *bucket;`
`213`	`213`
`214`	`214`	`php_error_docref(NULL, E_WARNING, "Unprocessed filter buckets remaining on input brigade");`
`215`	`215`	`while ((bucket = buckets_in->head)) {`