JIT: Disable recursive call optimization for VM without global register variables

dstogov · dstogov · commit 48d050ef7223 · 2021-09-21T14:30:56.000+03:00
A tail-call to VM handler from recursively called function may lead to
pass control to incorrect stack frame.
diff --git a/ext/opcache/jit/zend_jit_x86.dasc b/ext/opcache/jit/zend_jit_x86.dasc
@@ -10082,7 +10082,7 @@ static int zend_jit_do_fcall(dasm_State **Dst, const zend_op *opline, const zend
 						}
 					}
 
-					if (!trace && op_array == &func->op_array
+					if (GCC_GLOBAL_REGS && !trace && op_array == &func->op_array
 							&& num_args >= op_array->required_num_args) {
 						/* recursive call */
 						if (ZEND_OBSERVER_ENABLED) {

Original file line number	Diff line number	Diff line change
`@@ -10082,7 +10082,7 @@ static int zend_jit_do_fcall(dasm_State *Dst, const zend_op opline, const zend`
`10082`	`10082`	`}`
`10083`	`10083`	`}`
`10084`	`10084`
`10085`		`- if (!trace && op_array == &func->op_array`
	`10085`	`+ if (GCC_GLOBAL_REGS && !trace && op_array == &func->op_array`
`10086`	`10086`	`&& num_args >= op_array->required_num_args) {`
`10087`	`10087`	`/* recursive call */`
`10088`	`10088`	`if (ZEND_OBSERVER_ENABLED) {`