From bbc4c6bddc4a25c97c095032457f4fcbf97afeaa Mon Sep 17 00:00:00 2001 From: nicolasstelter Date: Wed, 5 Feb 2025 13:30:21 +0100 Subject: [PATCH 1/4] Update dash_wrapper.py added error message --- django_plotly_dash/dash_wrapper.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/django_plotly_dash/dash_wrapper.py b/django_plotly_dash/dash_wrapper.py index e62c11b..a986453 100644 --- a/django_plotly_dash/dash_wrapper.py +++ b/django_plotly_dash/dash_wrapper.py @@ -115,6 +115,9 @@ def get_local_stateless_by_name(name): ''' Locate a registered dash app by name, and return a DjangoDash instance encapsulating the app. ''' + if not name: + raise ValueError("Unable to find stateless DjangoApp. Name is required") + sa = usable_apps.get(name, None) if not sa: From 32ed87475d2034f26c263b9003a7c4ab479a3074 Mon Sep 17 00:00:00 2001 From: nicolasstelter Date: Fri, 7 Feb 2025 12:44:55 +0100 Subject: [PATCH 2/4] corrected names --- django_plotly_dash/models.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/django_plotly_dash/models.py b/django_plotly_dash/models.py index 6a4e74b..fe05436 100644 --- a/django_plotly_dash/models.py +++ b/django_plotly_dash/models.py @@ -62,11 +62,11 @@ def as_dash_app(self) -> DjangoDash: ''' Return a DjangoDash instance of the dash application ''' - dateless_dash_app = getattr(self, '_stateless_dash_app_instance', None) - if not dateless_dash_app: - dateless_dash_app = get_stateless_by_name(self.app_name) - setattr(self, '_stateless_dash_app_instance', dateless_dash_app) - return dateless_dash_app + stateless_dash_app = getattr(self, '_stateless_dash_app_instance', None) + if not stateless_dash_app: + stateless_dash_app = get_stateless_by_name(self.app_name) + setattr(self, '_stateless_dash_app_instance', stateless_dash_app) + return stateless_dash_app def find_stateless_by_name(name): ''' From 0815b27c99708d907fb304ada97dc67d2ce9cfff Mon Sep 17 00:00:00 2001 From: nicolasstelter Date: Mon, 10 Feb 2025 12:25:27 +0100 Subject: [PATCH 3/4] readablilty --- django_plotly_dash/dash_wrapper.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/django_plotly_dash/dash_wrapper.py b/django_plotly_dash/dash_wrapper.py index a986453..ed55483 100644 --- a/django_plotly_dash/dash_wrapper.py +++ b/django_plotly_dash/dash_wrapper.py @@ -155,7 +155,9 @@ class DjangoDash: To use, construct an instance of DjangoDash() in place of a Dash() one. ''' #pylint: disable=too-many-instance-attributes - def __init__(self, name=None, serve_locally=None, + def __init__(self, + name=None, + serve_locally=None, add_bootstrap_links=False, suppress_callback_exceptions=False, external_stylesheets=None, From 89578b72404471fe347d89d2c298e141ce98357e Mon Sep 17 00:00:00 2001 From: nicolasstelter Date: Mon, 10 Feb 2025 12:36:25 +0100 Subject: [PATCH 4/4] readability --- django_plotly_dash/dash_wrapper.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/django_plotly_dash/dash_wrapper.py b/django_plotly_dash/dash_wrapper.py index ed55483..2957a45 100644 --- a/django_plotly_dash/dash_wrapper.py +++ b/django_plotly_dash/dash_wrapper.py @@ -424,7 +424,10 @@ class WrappedDash(Dash): 'Wrapper around the Plotly Dash application instance' # pylint: disable=too-many-arguments, too-many-instance-attributes def __init__(self, - base_pathname=None, replacements=None, ndid=None, serve_locally=False, + base_pathname=None, + replacements=None, + ndid=None, + serve_locally=False, **kwargs): self._uid = ndid