Skip to content

Commit 9eb600a

Browse files
committed
Code review fixes
1 parent f15bb7d commit 9eb600a

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

README.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -274,10 +274,6 @@ It will monitor primary, secondary and SEO URLs:
274274

275275
Optimizely Content Cloud supports only primary URLs and Optimizely Commerce supports all three types of URLs.
276276

277-
There are two scheduled jobs:
278-
- *[Geta NotFoundHandler] Index content URLs* - as mentioned before, this job indexes URLs of content. Usually, it is required to run this job only once. All new content is automatically indexed. But if for some reason content publish events are not firing when creating new content (for example, during the import), then you should set this job to run frequently.
279-
- *[Geta NotFoundHandler] Register content move redirects* - this job creates redirects based on registered moved content. Normally, this job is not required at all, but there might be situations when content move is registered but redirect creation is not completed. This could happen during deployments. In this case, you can manually run this job or schedule it to run time to time to fix such issues.
280-
281277
# Scheduled jobs
282278

283279
Scheduled job - process that runs in background
@@ -305,6 +301,11 @@ services.AddNotFoundHandler(o =>
305301
- OptimizelyScheduler - uses Optimizely to schedule job runs.
306302
An Optimizely scheduled job was added - <code>[Geta NotFoundHandler] Suggestions cleanup job</code>.
307303

304+
Additionally, there are two optimizely scheduled jobs responsible for:
305+
- *[Geta NotFoundHandler] Index content URLs* - as mentioned before, this job indexes URLs of content. Usually, it is required to run this job only once. All new content is automatically indexed. But if for some reason content publish events are not firing when creating new content (for example, during the import), then you should set this job to run frequently.
306+
- *[Geta NotFoundHandler] Register content move redirects* - this job creates redirects based on registered moved content. Normally, this job is not required at all, but there might be situations when content move is registered but redirect creation is not completed. This could happen during deployments. In this case, you can manually run this job or schedule it to run time to time to fix such issues.
307+
308+
308309
# Troubleshooting
309310

310311
The module has extensive logging. Turn on debug logging for the `Geta.NotFoundHandler` namespace in your logging configuration.

src/Geta.NotFoundHandler/Core/ScheduledJobs/ApplicationBuilderExtensions.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ namespace Geta.NotFoundHandler.Core.ScheduledJobs;
1313

1414
public static class ApplicationBuilderExtensions
1515
{
16-
public static IApplicationBuilder UseScheduler(this IApplicationBuilder app)
16+
public static IApplicationBuilder UseInternalScheduler(this IApplicationBuilder app)
1717
{
1818
var services = app.ApplicationServices;
1919

@@ -29,7 +29,7 @@ public static IApplicationBuilder UseScheduler(this IApplicationBuilder app)
2929
})
3030
.OnError(x =>
3131
{
32-
logger.LogError(x, "Something went wrong, scheduled job fails with exception");
32+
logger.LogError(x, "Something went wrong, scheduled job failed with exception");
3333
});
3434

3535
return app;

src/Geta.NotFoundHandler/Infrastructure/Initialization/ApplicationBuilderExtensions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ public static IApplicationBuilder UseNotFoundHandler(this IApplicationBuilder ap
2828

2929
if (options.UseInternalScheduler)
3030
{
31-
app.UseScheduler();
31+
app.UseInternalScheduler();
3232
}
3333

3434
return app;

0 commit comments

Comments
 (0)