fix: tsc not all code paths return a value errors

Author: GetUsernameFromDatabase

src/commands/music/connect.ts

@@ -24,37 +24,42 @@ export class DisconnectCommand extends Command {
   public override async chatInputRun(
     interaction: Command.ChatInputCommandInteraction
   ) {
-    if (interaction.member instanceof GuildMember) {
-      const { emojis, voice, options } = this.container.client.utils;
-      const permissions = voice(interaction);
+    if (!(interaction.member instanceof GuildMember)) {
+      return interaction.reply('You need to be GuildMember');
+    }
 
-      if (permissions.member)
-        return interaction.reply({
-          content: permissions.member,
-          ephemeral: true,
-        });
-      if (permissions.client)
-        return interaction.reply({
-          content: permissions.client,
-          ephemeral: true,
-        });
-      const queue = useQueue(interaction.guild!.id);
-      const player = useMainPlayer();
+    const { emojis, voice, options } = this.container.client.utils;
+    const permissions = voice(interaction);
 
-      if (queue)
-        return interaction.reply({
-          content: `${emojis.error} | I am **already** in a voice channel`,
-          ephemeral: true,
-        });
+    if (permissions.member) {
+      return interaction.reply({
+        content: permissions.member,
+        ephemeral: true,
+      });
+    }
+    if (permissions.client) {
+      return interaction.reply({
+        content: permissions.client,
+        ephemeral: true,
+      });
+    }
 
-      const newQueue = player?.queues.create(
-        interaction.guild!.id,
-        options(interaction)
-      );
-      await newQueue?.connect(interaction.member.voice.channel!.id);
+    const player = useMainPlayer();
+    const queue = useQueue(interaction.guild!.id);
+    if (queue) {
       return interaction.reply({
-        content: `${emojis.success} | I have **successfully connected** to the voice channel`,
+        content: `${emojis.error} | I am **already** in a voice channel`,
+        ephemeral: true,
       });
     }
+
+    const newQueue = player?.queues.create(
+      interaction.guild!.id,
+      options(interaction)
+    );
+    await newQueue?.connect(interaction.member.voice.channel!.id);
+    return interaction.reply({
+      content: `${emojis.success} | I have **successfully connected** to the voice channel`,
+    });
   }
 }

src/utilities/auricle-utils.ts

@@ -60,8 +60,10 @@ export function voice(
   const memberVoice = (interaction.member as GuildMember).voice;
   return {
     get member() {
-      if (!memberVoice.channel)
+      if (!memberVoice.channel) {
         return `${emojis.error} | You **need** to be in a voice channel.`;
+      }
+      return;
     },
     get client() {
       const resolved = new PermissionsBitField([
@@ -73,19 +75,23 @@ export function voice(
         ?.permissionsFor(interaction.guild!.members.me!)
         .missing(resolved);
 
-      if (missingPerms && missingPerms.length > 0)
+      if (missingPerms && missingPerms.length > 0) {
         return `${
           emojis.error
         } | I am **missing** the required voice channel permissions: \`${missingPerms.join(
           ', '
         )}\``;
+      }
+      return;
     },
     get clientToMember() {
       if (
         interaction.guild?.members.me?.voice.channelId &&
         memberVoice.channelId !== interaction.guild?.members.me?.voice.channelId
-      )
+      ) {
         return `${emojis.error} | You are **not** in my voice channel`;
+      }
+      return;
     },
   };
 }