[V5] Use Swift 6 with complete concurrency checking (#902)

Author: laevandus

.github/workflows/smoke-checks.yml

@@ -65,8 +65,9 @@ jobs:
 
   build-xcode15:
     name: Build SDKs (Xcode 15)
-    runs-on: macos-14
-    if: ${{ github.event.inputs.record_snapshots != 'true' }}
+    runs-on: macos-15
+    #if: ${{ github.event.inputs.record_snapshots != 'true' }}
+    if: false
     env:
       XCODE_VERSION: "15.4"
     steps:

.swiftformat

@@ -1,6 +1,6 @@
 # Stream rules
 --header "\nCopyright © {year} Stream.io Inc. All rights reserved.\n"
---swiftversion 5.9
+--swiftversion 6.0
 
 --ifdef no-indent
 --disable redundantType

.swiftlint.yml

@@ -43,14 +43,10 @@ only_rules:
   - trailing_comma
   - trailing_newline
   - trailing_semicolon
-  - trailing_whitespace
   - unneeded_break_in_switch
   - unneeded_override
   - unused_closure_parameter
   - unused_control_flow_label
   - unused_import
   - vertical_whitespace
   - void_return
-
-trailing_whitespace:
-  ignores_empty_lines: true

DemoAppSwiftUI/AppConfiguration/AppConfiguration.swift

@@ -7,7 +7,7 @@ import StreamChat
 import StreamChatSwiftUI
 
 final class AppConfiguration {
-    static let `default` = AppConfiguration()
+    @MainActor static let `default` = AppConfiguration()
 
     /// The translation language to set on connect.
     var translationLanguage: TranslationLanguage?

DemoAppSwiftUI/AppConfiguration/AppConfigurationTranslationView.swift

@@ -8,23 +8,17 @@ import SwiftUI
 struct AppConfigurationTranslationView: View {
     @Environment(\.dismiss) var dismiss
 
-    var selection: Binding<TranslationLanguage?> = Binding {
-        AppConfiguration.default.translationLanguage
-    } set: { newValue in
-        AppConfiguration.default.translationLanguage = newValue
-    }
-    
     var body: some View {
         List {
             ForEach(TranslationLanguage.all, id: \.languageCode) { language in
                 Button(action: {
-                    selection.wrappedValue = language
+                    AppConfiguration.default.translationLanguage = language
                     dismiss()
                 }) {
                     HStack {
                         Text(language.languageCode)
                         Spacer()
-                        if selection.wrappedValue == language {
+                        if AppConfiguration.default.translationLanguage == language {
                             Image(systemName: "checkmark")
                         }
                     }

DemoAppSwiftUI/AppConfiguration/AppConfigurationView.swift

@@ -6,11 +6,7 @@ import Combine
 import SwiftUI
 
 struct AppConfigurationView: View {
-    var channelPinningEnabled: Binding<Bool> = Binding {
-        AppConfiguration.default.isChannelPinningFeatureEnabled
-    } set: { newValue in
-        AppConfiguration.default.isChannelPinningFeatureEnabled = newValue
-    }
+    @State private var channelPinningEnabled = AppConfiguration.default.isChannelPinningFeatureEnabled
 
     var body: some View {
         NavigationView {
@@ -19,12 +15,13 @@ struct AppConfigurationView: View {
                     NavigationLink("Translation") {
                         AppConfigurationTranslationView()
                     }
-                    Toggle("Channel Pinning", isOn: channelPinningEnabled)
+                    Toggle("Channel Pinning", isOn: $channelPinningEnabled)
                 }
             }
             .navigationBarTitleDisplayMode(.inline)
             .navigationTitle("App Configuration")
         }
+        .onChange(of: channelPinningEnabled, perform: { AppConfiguration.default.isChannelPinningFeatureEnabled = $0 })
     }
 }
 

DemoAppSwiftUI/AppleMessageComposerView.swift

@@ -125,8 +125,10 @@ struct AppleMessageComposerView<Factory: ViewFactory>: View, KeyboardReadable {
             }
         )
         .onPreferenceChange(HeightPreferenceKey.self) { value in
-            if let value = value, value != composerHeight {
-                self.composerHeight = value
+            Task { @MainActor in
+                if let value = value, value != composerHeight {
+                    self.composerHeight = value
+                }
             }
         }
         .onReceive(keyboardWillChangePublisher) { visible in
@@ -159,7 +161,7 @@ struct AppleMessageComposerView<Factory: ViewFactory>: View, KeyboardReadable {
                     }
                 )
                 .offset(y: -composerHeight)
-                .animation(nil) : nil,
+                .animation(.none, value: viewModel.showCommandsOverlay) : nil,
             alignment: .bottom
         )
         .modifier(factory.makeComposerViewModifier())
@@ -213,7 +215,7 @@ struct BlurredBackground: View {
 }
 
 struct HeightPreferenceKey: PreferenceKey {
-    static var defaultValue: CGFloat?
+    static var defaultValue: CGFloat? { nil }
 
     static func reduce(value: inout CGFloat?, nextValue: () -> CGFloat?) {
         value = value ?? nextValue()

DemoAppSwiftUI/ChannelHeader/BlockedUsersViewModel.swift

@@ -6,7 +6,7 @@ import StreamChat
 import StreamChatSwiftUI
 import SwiftUI
 
-class BlockedUsersViewModel: ObservableObject {
+@MainActor class BlockedUsersViewModel: ObservableObject {
     @Injected(\.chatClient) var chatClient
 
     @Published var blockedUsers = [ChatUser]()

DemoAppSwiftUI/ChannelHeader/ChooseChannelQueryView.swift

@@ -7,7 +7,9 @@ import StreamChatSwiftUI
 import SwiftUI
 
 struct ChooseChannelQueryView: View {
-    static let queryIdentifiers = ChannelListQueryIdentifier.allCases.sorted(using: KeyPathComparator(\.title))
+    static var queryIdentifiers: [ChannelListQueryIdentifier] {
+        ChannelListQueryIdentifier.allCases.sorted(by: { $0.title < $1.title })
+    }
 
     var body: some View {
         ForEach(Self.queryIdentifiers) { queryIdentifier in

DemoAppSwiftUI/ChannelHeader/NewChatViewModel.swift

@@ -6,7 +6,7 @@ import StreamChat
 import StreamChatSwiftUI
 import SwiftUI
 
-class NewChatViewModel: ObservableObject, ChatUserSearchControllerDelegate {
+@MainActor class NewChatViewModel: ObservableObject, ChatUserSearchControllerDelegate {
     @Injected(\.chatClient) var chatClient
 
     @Published var searchText: String = "" {