Fixes #26

    Request body was build the wrong way when no additional params where
    passed to Repository::create()

    Added additional test which should cover this issue.

Author: vimishor

lib/Bitbucket/API/Repositories/Repository.php

@@ -48,6 +48,8 @@ public function get($account, $repo)
      * @param  array            $params  Additional parameters
      * @return MessageInterface
      *
+     * @throws \InvalidArgumentException If invalid JSON is provided.
+     *
      * @see https://confluence.atlassian.com/x/WwZAGQ
      */
     public function create($account, $repo, $params = array())
@@ -58,20 +60,25 @@ public function create($account, $repo, $params = array())
             return $this->createLegacy($account, $repo);
         }
 
+        $defaults = array(
+            'scm'               => 'git',
+            'name'              => $repo,
+            'is_private'        => true,
+            'description'       => 'My secret repo',
+            'forking_policy'    => 'no_forks',
+        );
+
         // allow developer to directly specify params as json if (s)he wants.
-        if (!empty($params) && is_array($params)) {
-            $params = json_encode(array_merge(
-                array(
-                    'scm'               => 'git',
-                    'name'              => $repo,
-                    'is_private'        => true,
-                    'description'       => 'My secret repo',
-                    'forking_policy'    => 'no_forks',
-                ),
-                $params
-            ));
+        if ('string' === gettype($params)) {
+            $params = json_decode($params, true);
+
+            if (JSON_ERROR_NONE !== json_last_error()) {
+                throw new \InvalidArgumentException('Invalid JSON provided.');
+            }
         }
 
+        $params = json_encode(array_merge($defaults, $params));
+
         return $this->getClient()->setApiVersion('2.0')->post(
             sprintf('repositories/%s/%s', $account, $repo),
             $params,

test/Bitbucket/Tests/API/Repositories/RepositoryTest.php

@@ -69,6 +69,31 @@ public function testCreateRepositoryFromArray()
         $repo->create('gentle', 'new-repo', $params);
     }
 
+    /**
+     * @ticket 26
+     */
+    public function testCreateRepositoryWithDefaultParams()
+    {
+        $endpoint       = 'repositories/gentle/new-repo';
+        $params         = array(
+            'scm'               => 'git',
+            'name'              => 'new-repo',
+            'is_private'        => true,
+            'description'       => 'My secret repo',
+            'forking_policy'    => 'no_forks',
+        );
+
+        $client = $this->getHttpClientMock();
+        $client->expects($this->once())
+            ->method('post')
+            ->with($endpoint, json_encode($params));
+
+        /** @var \Bitbucket\API\Repositories\Repository $repo */
+        $repo   = $this->getClassMock('Bitbucket\API\Repositories\Repository', $client);
+
+        $repo->create('gentle', 'new-repo', array());
+    }
+
     public function testCreateRepositorySuccess()
     {
         $endpoint       = 'repositories';