Client::setApiVersion argument type

setApiVersion method should accept only string
type argument.

fixes #57

Author: vimishor

lib/Bitbucket/API/Http/Client.php

@@ -187,7 +187,7 @@ public function getApiVersion()
      */
     public function setApiVersion($version)
     {
-        if (!in_array($version, $this->options['api_versions'])) {
+        if (!in_array($version, $this->options['api_versions'], true)) {
             throw new \InvalidArgumentException(sprintf('Unsupported API version %s', $version));
         }
 

lib/Bitbucket/API/Http/ClientInterface.php

@@ -109,7 +109,7 @@ public function getApiVersion();
      * Supported versions: 1.0, 2.0
      *
      * @access public
-     * @param  float $version
+     * @param  string $version
      * @return $this
      *
      * @throws \InvalidArgumentException If invalid API version is provided

test/Bitbucket/Tests/API/Http/ClientTest.php

@@ -43,11 +43,13 @@ public function testResponseFormatSuccess()
     }
 
     /**
+     * @dataProvider invalidApiVersionsProvider
      * @expectedException \InvalidArgumentException
+     * @ticket 57
      */
-    public function testSetApiVersionInvalid()
+    public function testSetApiVersionInvalid($version)
     {
-        $this->client->setApiVersion('1.1.1');
+        $this->client->setApiVersion($version);
     }
 
     public function testApiVersionSuccess()
@@ -202,4 +204,11 @@ private function getListenerMock($name = 'dummy')
 
         return $listener;
     }
+
+    public function invalidApiVersionsProvider()
+    {
+        return [
+            ['3.1'], ['1,2'], ['1,0'], ['2.1'], ['4'], [2], ['string'], [2.0]
+        ];
+    }
 }