added Api::childFactory

This method exists only to help keeping BC for authentification when getting a child class.
  - If a Auth listener exists in parent, it will be passed to child on first instantiation.

@todo: To be removed on next major version release.

Author: vimishor

lib/Bitbucket/API/Api.php

@@ -263,4 +263,37 @@ protected function processResponse(\Buzz\Message\MessageInterface $response)
                 break;
         }
     }
+
+    /**
+     * Factory for child classes
+     *
+     * NOTE: This exists only to keep BC. Do not rely on this factory because
+     * it will be removed in a future version!
+     *
+     * @access protected
+     * @param  string $name
+     * @return mixed
+     *
+     * @throws \InvalidArgumentException
+     */
+    protected function childFactory($name)
+    {
+        if (empty($name)) {
+            throw new \InvalidArgumentException('Not child specified.');
+        }
+
+        /** @var Api $child */
+        $class = '\\Bitbucket\\API\\'.$name;
+        $child = new $class($this->client);
+
+        if ($this->getClient()->isListener('basicauth')) {
+            $child->getClient()->addListener($this->getClient()->getListener('basicauth'));
+        }
+
+        if ($this->getClient()->isListener('oauth')) {
+            $child->getClient()->addListener($this->getClient()->getListener('oauth'));
+        }
+
+        return $child;
+    }
 }

lib/Bitbucket/API/Groups.php

@@ -111,12 +111,6 @@ public function delete($account, $name)
      */
     public function members()
     {
-        $members = new Groups\Members( $this->client );
-
-        if ( !is_null($this->auth) ) {
-            $members->setCredentials( $this->auth );
-        }
-
-        return $members;
+        return $this->childFactory('Groups\\Members');
     }
 }

lib/Bitbucket/API/Repositories/Changesets.php

@@ -100,12 +100,6 @@ public function diff($account, $repo, $node)
      */
     public function comments()
     {
-        $comments = new Changesets\Comments( $this->client );
-
-        if ( !is_null($this->auth) ) {
-            $comments->setCredentials( $this->auth );
-        }
-
-        return $comments;
+        return $this->childFactory('Repositories\\Changesets\\Comments');
     }
 }

lib/Bitbucket/API/Repositories/Issues.php

@@ -146,13 +146,7 @@ public function delete($account, $repo, $issueID)
      */
     public function comments()
     {
-        $comments = new Repositories\Issues\Comments( $this->client );
-
-        if ( !is_null($this->auth)) {
-            $comments->setCredentials( $this->auth );
-        }
-
-        return $comments;
+        return $this->childFactory('Repositories\\Issues\\Comments');
     }
 
     /**
@@ -164,13 +158,7 @@ public function comments()
      */
     public function components()
     {
-        $components = new Repositories\Issues\Components( $this->client );
-
-        if ( !is_null($this->auth) ) {
-            $components->setCredentials( $this->auth );
-        }
-
-        return $components;
+        return $this->childFactory('Repositories\\Issues\\Components');
     }
 
     /**
@@ -182,13 +170,7 @@ public function components()
      */
     public function versions()
     {
-        $versions = new Repositories\Issues\Versions( $this->client );
-
-        if ( !is_null($this->auth) ) {
-            $versions->setCredentials( $this->auth );
-        }
-
-        return $versions;
+        return $this->childFactory('Repositories\\Issues\\Versions');
     }
 
     /**
@@ -200,12 +182,6 @@ public function versions()
      */
     public function milestones()
     {
-        $milestones = new Repositories\Issues\Milestones( $this->client );
-
-        if ( !is_null($this->auth) ) {
-            $milestones->setCredentials( $this->auth );
-        }
-
-        return $milestones;
+        return $this->childFactory('Repositories\\Issues\\Milestones');
     }
 }

lib/Bitbucket/API/Repositories/PullRequests.php

@@ -31,12 +31,6 @@ class PullRequests extends API\Api
      */
     public function comments()
     {
-        $comments = new PullRequests\Comments( $this->client );
-
-        if ( !is_null($this->auth)) {
-            $comments->setCredentials( $this->auth );
-        }
-
-        return $comments;
+        return $this->childFactory('Repositories\\PullRequests\\Comments');
     }
 }

lib/Bitbucket/API/User.php

@@ -76,12 +76,6 @@ public function follows()
      */
     public function repositories()
     {
-        $repositories = new User\Repositories( $this->client );
-
-        if ( !is_null($this->auth) ) {
-            $repositories->setCredentials( $this->auth );
-        }
-
-        return $repositories;
+        return $this->childFactory('User\\Repositories');
     }
 }

lib/Bitbucket/API/Users.php

@@ -29,13 +29,7 @@ class Users extends Api
      */
     public function account()
     {
-        $account = new Users\Account( $this->client );
-
-        if ( !is_null($this->auth) ) {
-            $account->setCredentials( $this->auth );
-        }
-
-        return $account;
+        return $this->childFactory('Users\\Account');
     }
 
     /**
@@ -46,13 +40,7 @@ public function account()
      */
     public function emails()
     {
-        $emails = new Users\Emails( $this->client );
-
-        if ( !is_null($this->auth) ) {
-            $emails->setCredentials( $this->auth );
-        }
-
-        return $emails;
+        return $this->childFactory('Users\\Emails');
     }
 
     /**
@@ -63,13 +51,7 @@ public function emails()
      */
     public function invitations()
     {
-        $invitations = new Users\Invitations( $this->client );
-
-        if ( !is_null($this->auth) ) {
-            $invitations->setCredentials( $this->auth );
-        }
-
-        return $invitations;
+        return $this->childFactory('Users\\Invitations');
     }
 
     /**
@@ -80,13 +62,7 @@ public function invitations()
      */
     public function oauth()
     {
-        $oauth = new Users\OAuth( $this->client );
-
-        if ( !is_null($this->auth) ) {
-            $oauth->setCredentials( $this->auth );
-        }
-
-        return $oauth;
+        return $this->childFactory('Users\\OAuth');
     }
 
     /**
@@ -97,13 +73,7 @@ public function oauth()
      */
     public function privileges()
     {
-        $privileges = new Users\Privileges( $this->client );
-
-        if ( !is_null($this->auth) ) {
-            $privileges->setCredentials( $this->auth );
-        }
-
-        return $privileges;
+        return $this->childFactory('Users\\Privileges');
     }
 
     /**
@@ -114,12 +84,6 @@ public function privileges()
      */
     public function sshKeys()
     {
-        $keys = new Users\SshKeys( $this->client );
-
-        if ( !is_null($this->auth) ) {
-            $keys->setCredentials( $this->auth );
-        }
-
-        return $keys;
+        return $this->childFactory('Users\\SshKeys');
     }
-}
+}