Merge branch 'hotfix/0.8.3' into support/0.8

* hotfix/0.8.3:
  updated CHANGELOG and version bumped to 0.8.3
  Client::setApiVersion argument type should be of type string

Author: vimishor

CHANGELOG.md

@@ -2,6 +2,12 @@
 All notable changes to this project will be documented in this file.  
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## 0.8.3 / 2017-05-15
+
+### Fixed:
+  - Client::setApiVersion should accept only argument of type string (issue #57)
+
+
 ## 0.8.2 / 2017-01-10
 
 ### Fixed:

lib/Bitbucket/API/Http/Client.php

@@ -33,7 +33,7 @@ class Client extends ClientListener implements ClientInterface
         'api_versions'  => array('1.0', '2.0'),     // supported versions
         'format'        => 'json',
         'formats'       => array('json', 'xml'),    // supported response formats
-        'user_agent'    => 'bitbucket-api-php/0.8.2 (https://bitbucket.org/gentlero/bitbucket-api)',
+        'user_agent'    => 'bitbucket-api-php/0.8.3 (https://bitbucket.org/gentlero/bitbucket-api)',
         'timeout'       => 10,
         'verify_peer'   => false
     );
@@ -187,7 +187,7 @@ public function getApiVersion()
      */
     public function setApiVersion($version)
     {
-        if (!in_array($version, $this->options['api_versions'])) {
+        if (!in_array($version, $this->options['api_versions'], true)) {
             throw new \InvalidArgumentException(sprintf('Unsupported API version %s', $version));
         }
 

lib/Bitbucket/API/Http/ClientInterface.php

@@ -109,7 +109,7 @@ public function getApiVersion();
      * Supported versions: 1.0, 2.0
      *
      * @access public
-     * @param  float $version
+     * @param  string $version
      * @return $this
      *
      * @throws \InvalidArgumentException If invalid API version is provided

test/Bitbucket/Tests/API/Http/ClientTest.php

@@ -43,11 +43,13 @@ public function testResponseFormatSuccess()
     }
 
     /**
+     * @dataProvider invalidApiVersionsProvider
      * @expectedException \InvalidArgumentException
+     * @ticket 57
      */
-    public function testSetApiVersionInvalid()
+    public function testSetApiVersionInvalid($version)
     {
-        $this->client->setApiVersion('1.1.1');
+        $this->client->setApiVersion($version);
     }
 
     public function testApiVersionSuccess()
@@ -202,4 +204,11 @@ private function getListenerMock($name = 'dummy')
 
         return $listener;
     }
+
+    public function invalidApiVersionsProvider()
+    {
+        return [
+            ['3.1'], ['1,2'], ['1,0'], ['2.1'], ['4'], [2], ['string'], [2.0]
+        ];
+    }
 }