updated tests for Repositories/Repository

Author: vimishor

test/Bitbucket/Tests/API/Repositories/RepositoryTest.php

@@ -32,6 +32,7 @@ public function invalidCreateProvider()
     {
         return array(
             array(''),
+            array(3),
             array("\t"),
             array("\n"),
             array(' '),
@@ -41,26 +42,23 @@ public function invalidCreateProvider()
             array(
                 substr(
                     "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ",
-                    mt_rand( 0 ,50 ) ,1 ) .substr( md5( time() ), 1)
-            )
+                    mt_rand(0, 50), 1).substr(md5(time()), 1),
+            ),
         );
-
     }
 
     /**
-     * @param $check
-     * @param $expectation
-     * @return mixed
+     * @param mixed $check
      * @expectedException \InvalidArgumentException
-     *  @dataProvider invalidCreateProvider
+     * @dataProvider invalidCreateProvider
+     * @ticket 27, 26
      */
     public function testInvalidCreate($check)
     {
-
-        $client     = $this->getHttpClientMock();
+        $client = $this->getHttpClientMock();
 
         /** @var \Bitbucket\API\Repositories\Repository $repo */
-        $repo   = $this->getClassMock('Bitbucket\API\Repositories\Repository', $client);
+        $repo = $this->getClassMock('Bitbucket\API\Repositories\Repository', $client);
         $this->setExpectedException('\InvalidArgumentException');
         $repo->create('gentle', 'new-repo', $check);
     }
@@ -134,28 +132,14 @@ public function testCreateRepositoryWithDefaultParams()
         $repo->create('gentle', 'new-repo', array());
     }
 
-    /**
-     * @ticket 26
-     * @expectedException \InvalidArgumentException
-     */
-    public function testCreateRepositoryWithWrongParamsType()
-    {
-        /** @var \Bitbucket\API\Repositories\Repository $repo */
-        $repo   = $this->getApiMock('Bitbucket\API\Repositories\Repository');
-
-        $repo->create('gentle', 'new-repo', '');
-        $repo->create('gentle', 'new-repo', 3);
-        $repo->create('gentle', 'new-repo', "{ 'foo': 'bar' }");
-    }
-
     public function testCreateRepositorySuccess()
     {
         $endpoint       = 'repositories';
         $params         = array(
             'name'          => 'secret',
             'description'   => 'My super secret project',
             'language'      => 'php',
-            'is_private'    => true
+            'is_private'    => true,
         );
 
         $repository = $this->getApiMock('Bitbucket\API\Repositories\Repository');
@@ -174,7 +158,7 @@ public function testUpdateRepositorySuccess()
             'description'   => 'My super secret project',
             'language'      => 'php',
             'is_private'    => false,
-            'main_branch'   => 'master'
+            'main_branch'   => 'master',
         );
 
         $repository = $this->getApiMock('Bitbucket\API\Repositories\Repository');
@@ -242,7 +226,7 @@ public function testForkRepositorySuccess()
         $endpoint       = 'repositories/gentle/eof/fork';
         $params         = array(
             'name'          => 'my-eof',
-            'is_private'    => true
+            'is_private'    => true,
         );
 
         $repository = $this->getApiMock('Bitbucket\API\Repositories\Repository');
@@ -263,7 +247,7 @@ public function testGetBranches()
         $repository->expects($this->once())
             ->method('requestGet')
             ->with($endpoint)
-            ->will( $this->returnValue($expectedResult) );
+            ->will($this->returnValue($expectedResult));
 
         /** @var $repository \Bitbucket\API\Repositories\Repository */
         $actual = $repository->branches('gentle', 'eof');
@@ -280,7 +264,7 @@ public function testGetMainBranch()
         $repository->expects($this->once())
             ->method('requestGet')
             ->with($endpoint)
-            ->will( $this->returnValue($expectedResult) );
+            ->will($this->returnValue($expectedResult));
 
         /** @var $repository \Bitbucket\API\Repositories\Repository */
         $actual = $repository->branch('gentle', 'eof');
@@ -297,7 +281,7 @@ public function testGetManifest()
         $repository->expects($this->once())
             ->method('requestGet')
             ->with($endpoint)
-            ->will( $this->returnValue($expectedResult) );
+            ->will($this->returnValue($expectedResult));
 
         /** @var $repository \Bitbucket\API\Repositories\Repository */
         $actual = $repository->manifest('gentle', 'eof', 'develop');
@@ -314,7 +298,7 @@ public function testGetTags()
         $repository->expects($this->once())
             ->method('requestGet')
             ->with($endpoint)
-            ->will( $this->returnValue($expectedResult) );
+            ->will($this->returnValue($expectedResult));
 
         /** @var $repository \Bitbucket\API\Repositories\Repository */
         $actual = $repository->tags('gentle', 'eof');
@@ -331,7 +315,7 @@ public function testGetRawSource()
         $repository->expects($this->once())
             ->method('requestGet')
             ->with($endpoint)
-            ->will( $this->returnValue($expectedResult) );
+            ->will($this->returnValue($expectedResult));
 
         /** @var $repository \Bitbucket\API\Repositories\Repository */
         $actual = $repository->raw('gentle', 'eof', '1bc8345', 'lib/file.php');
@@ -348,7 +332,7 @@ public function testGetFileHistory()
         $repository->expects($this->once())
             ->method('requestGet')
             ->with($endpoint)
-            ->will( $this->returnValue($expectedResult) );
+            ->will($this->returnValue($expectedResult));
 
         /** @var $repository \Bitbucket\API\Repositories\Repository */
         $actual = $repository->filehistory('gentle', 'eof', '1bc8345', 'lib/file.php');