mmandatory parameters inside PullRequest's methods are now checked.

Author: vimishor

lib/Bitbucket/API/Http/Listener/RequestListener.php

@@ -36,6 +36,11 @@ public function preSend(RequestInterface $request)
             // Transform: "foo[0]=xxx&foo[1]=yyy" to "foo=xxx&foo=yyy"
             preg_replace('/%5B(?:[0-9]|[1-9][0-9]+)%5D=/', '=', $request->getContent())
         );
+
+        $request->setResource(
+            // Transform: "foo[0]=xxx&foo[1]=yyy" to "foo=xxx&foo=yyy"
+            preg_replace('/%5B(?:[0-9]|[1-9][0-9]+)%5D=/', '=', $request->getResource())
+        );
     }
 
     /**

lib/Bitbucket/API/Repositories/PullRequests.php

@@ -41,16 +41,32 @@ public function comments()
      * @param  string           $repo    The repository identifier.
      * @param  array            $params  Additional parameters
      * @return MessageInterface
+     *
+     * @throws \InvalidArgumentException
      */
     public function all($account, $repo, $params = array())
     {
+        $states = array('OPEN', 'MERGED', 'DECLINED');
         $params = array_merge(
             array(
                 'state' => 'OPEN'
             ),
             $params
         );
 
+        if (!is_array($params['state'])) {
+            $params['state'] = array($params['state']);
+        }
+
+        array_walk(
+            $params['state'],
+            function ($state) use ($states) {
+                if (!in_array($state, $states)) {
+                    throw new \InvalidArgumentException(sprintf('Unknown `state` %s', $state));
+                }
+            }
+        );
+
         return $this->getClient()->setApiVersion('2.0')->get(
             sprintf('repositories/%s/%s/pullrequests', $account, $repo),
             $params
@@ -66,6 +82,7 @@ public function all($account, $repo, $params = array())
      * @param  array            $params  Additional parameters
      * @return MessageInterface
      *
+     * @throws \InvalidArgumentException
      * @see https://confluence.atlassian.com/x/XAZAGQ
      */
     public function create($account, $repo, $params = array())
@@ -85,6 +102,14 @@ public function create($account, $repo, $params = array())
             ));
         }
 
+        if (empty($params['title'])) {
+            throw new \InvalidArgumentException('Pull request\'s title must be specified.');
+        }
+
+        if (empty($params['source']['branch']['name'])) {
+            throw new \InvalidArgumentException('Pull request\'s source branch name must be specified.');
+        }
+
         return $this->getClient()->setApiVersion('2.0')->post(
             sprintf('repositories/%s/%s/pullrequests', $account, $repo),
             $params,
@@ -101,6 +126,8 @@ public function create($account, $repo, $params = array())
      * @param  int              $id      ID of the pull request that will be updated
      * @param  array            $params  Additional parameters
      * @return MessageInterface
+     *
+     * @throws \InvalidArgumentException
      */
     public function update($account, $repo, $id, $params = array())
     {
@@ -119,6 +146,14 @@ public function update($account, $repo, $id, $params = array())
             ));
         }
 
+        if (empty($params['title'])) {
+            throw new \InvalidArgumentException('Pull request\'s title must be specified.');
+        }
+
+        if (empty($params['destination']['branch']['name'])) {
+            throw new \InvalidArgumentException('Pull request\'s destination branch name must be specified.');
+        }
+
         return $this->getClient()->setApiVersion('2.0')->put(
             sprintf('repositories/%s/%s/pullrequests/%d', $account, $repo, $id),
             $params,