Avoid calling extrema(...; dims) with empty arrays. See PR #1711 (#1713)

Author: joa-quim

src/extras/lowess.jl

@@ -40,7 +40,9 @@ function lowess(x::AbstractVector{R}, y::AbstractVector{S}; span::T=2/3, nsteps:
 	lowess((R <: AbstractFloat) ? x : Vector{Float64}(x), (S <: AbstractFloat) ? y : Vector{Float64}(y); span=span, nsteps=nsteps, delta=delta)
 end
 
-function lowess(mat::Matrix{<:Real}; span=2/3, nsteps::Integer=3, delta=0.1*diff(collect(extrema(view(mat, :,2))), dims=1)[1])
+function lowess(mat::Matrix{<:Real}; span=2/3, nsteps::Integer=3, delta=0.0)
+	isempty(mat) && error("lowess: 'mat' cannot be an empty matrix")
+	(delta == 0.0) && (delta = 0.1*diff(collect(extrema(view(mat, :,2))), dims=1)[1])
 	new_y = lowess(view(mat, :,1), view(mat, :,2); span=span, nsteps=nsteps, delta=delta)
 	return [mat[:,1] new_y]
 end

src/gmt_main.jl

@@ -1431,6 +1431,7 @@ function ogr2GMTdataset(in::Ptr{OGR_FEATURES}, drop_islands=false)::Union{GMTdat
 	end
 	(n_total_segments > (n-1)) && deleteat!(D, n:n_total_segments)
 	for k = 1:length(D)			# Compute the BoundingBoxes per segment (C version doesn't do it)
+		isempty(D[k].data) && continue		# #1711
 		bb = Base.invokelatest(extrema, D[k].data, dims=1)		# A N Tuple.
 		D[k].bbox = collect(Float64, Iterators.flatten(bb))
 	end

src/grd_operations.jl

@@ -467,6 +467,7 @@ function rotate(FV::GMTfv, a=Float64[]; rx=0.0, ry=0.0, rz=0.0, insitu::Bool=fal
 	!isempty(a) && (@assert length(a) == 3 "Angle vector must be of length 3")
 	isempty(a) && (a = [rx, ry, rz])
 	V = FV.verts * eulermat(a)[1]
+	isempty(V) && error("The 'V' input cannot be empty.")		# #1711		
 	mimas = extrema(V, dims=1)
 	bbox = [mimas[1][1], mimas[1][2], mimas[2][1], mimas[2][2], mimas[3][1], mimas[3][2]]		# So stu..
 	if insitu

src/imgtiles.jl

@@ -708,6 +708,7 @@ function quadbounds_limits(quadtree::Matrix{<:AbstractString}; geog=true, quadke
 	flatness = 0.0
 
 	tiles_bb = zeros(length(quadtree), 4)
+	isempty(tiles_bb) && error("The 'quadtree' input cannot be empty.")		# #1711		
 	zoomL = 0			# Can't stand this need. F. F. F
 	for k = 1:length(quadtree)
 		lim, zoomL = getQuadLims(quadtree[k], quadkey, "")		# Remember that lim(3) = y_max

src/laszip/lazwrite.jl

@@ -23,6 +23,7 @@ end
 function lazwrite(fname::AbstractString, xyz; grd_hdr=Float64[], scaleX=nothing, scaleY=nothing, scaleZ=nothing,
                   offX=nothing, offY=nothing, offZ=nothing, layout::String="")
 
+	isempty(xyz) && error("The 'xyz' input cannot be empty as it is.")
 	n_rows, n_cols = parse_inputs_dat2las(xyz, grd_hdr)
 
 	if (!isempty(grd_hdr))

src/linefit.jl

@@ -245,6 +245,7 @@ function plotlinefit(D::GMTdataset; first::Bool=true, grp::Bool=false, kw...)
 	tl, bl = (a - σa) .+ (b + σb)*X,  (a + σa) .+ (b - σb)*X
 	recta = a .+ b * X
 	if (do_rib_ab)
+		(isempty(tl) || isempty(bl)) && error("One of 'tl'' or ''bl'' is empty.");	# Should never happen but see #1711
 		σp, σm = vec(maximum([tl bl], dims=2)) .- recta, recta .- vec(minimum([tl bl], dims=2))
 	end
 

src/plot.jl

@@ -909,6 +909,7 @@ function stem(cmd0::String="", arg1=nothing; first=true, kwargs...)
 			add2ds!(arg1[1])		# Fix arg1 meta after column insertion.
 		end
 	else							# Case of plain matrices
+		isempty(arg1) && error("stem: 'arg1' cannot be empty.")
 		if (!haveR)
 			mm = extrema(arg1, dims=1)
 			mimas = [mm[1][1], mm[1][2], mm[2][1], mm[2][2]]
@@ -1080,6 +1081,8 @@ end
 function helper_vecBug(d, arg1, first::Bool, haveR::Bool, haveVarFill::Bool, typevec::Int; isfeather::Bool=false)
 	# Helper function that deals with setting several defaults and mostly patch a GMT vectors bug.
 	# TYPEVEC = 0, ==> u,v = theta,rho. TYPEVEC = 1, ==> u,v = u,v. TYPEVEC = 2, ==> u,v = x2,y2 
+
+	isempty(arg1) && error("'arg1' input cannot be empty.")
 
 	function get_minmaxs(D::GMTdataset)
 		# Get x,y minmax from datasets that may have had teir columns rearranged.

src/pshistogram.jl

@@ -166,6 +166,7 @@ function histogram_helper(cmd0::String, arg1; first=true, kwargs...)
 	do_zoom = ((find_in_dict(d, [:zoom])[1]) !== nothing) ? true : false	# Automatic zoom to interesting region
 
 	function if_zoom(cmd, opt_R, limit_L, hst)
+		isempty(hst) && error("No histogram data to compute the region limits.")
 		mm = extrema(hst, dims=1)			# 1×2 Array{Tuple{UInt16,UInt16},2}
 		x_max = min(limit_R * 1.15, hst[end,1])		# 15% to the right but not fall the cliff
 		opt_R_ = " -R$(limit_L * 0.85)/$x_max/0/$(mm[2][2] * 1.1) "
@@ -259,6 +260,7 @@ function histogram_helper(cmd0::String, arg1; first=true, kwargs...)
 	# And if wished, plot the two vertical lines with the limits annotated in them
 	if (limit_L !== nothing)
 		if (opt_R == " ")					# Set a region for the vlines
+			isempty(hst) && error("No histogram data to compute the region limits.")
 			mm = extrema(hst, dims=1)
 			opt_R = " -R$(mm[1][1])/$(mm[1][2])/0/$(mm[2][2])"
 		end

src/statplots.jl

@@ -1108,6 +1108,7 @@ function parplot_helper(cmd0::String, arg1; first::Bool=true, axeslabels::Vector
                       labels::Vector{String}=String[], group::AbstractVector=AbstractVector[], groupvar="", normalize="range", kwargs...)
 	d = KW(kwargs)
 	(cmd0 != "") && (arg1 = read_data(d, cmd0, "", arg1, " ", false, true)[2])	# Make sure we have the data here
+	isempty(arg1) && error("The 'arg1' input cannot be empty.")		# #1711		
 	if     (isa(arg1, Matrix{<:Real}))        data = mat2ds(arg1)
 	elseif (isa(arg1, Vector{<:GMTdataset}))  data = ds2ds(arg1)
 	else                                      data = mat2ds(arg1)

src/utils_types.jl

@@ -544,6 +544,7 @@ function set_dsBB!(D, all_bbs::Bool=true)
 
 	if (all_bbs)		# Compute all BBs
 		if isa(D, GMTdataset)
+			isempty(D.data) && return nothing		# Likely a Text only DS
 			D.ds_bbox = D.bbox = collect(Float64, Iterators.flatten(extrema(D.data, dims=1)))
 			ind = findall(.!isfinite.(D.bbox))		# If we have some columns with NaNs or Infs
 			if (!isempty(ind))
@@ -555,6 +556,7 @@ function set_dsBB!(D, all_bbs::Bool=true)
 			return nothing
 		else
 			for k = 1:lastindex(D)
+				isempty(D[k].data) && continue		# Likely a Text only DS
 				bb = Base.invokelatest(extrema, D[k].data, dims=1)		# A N Tuple.
 				_bb = collect(Float64, Iterators.flatten(bb))
 				if (any(isnan.(_bb)))				# Shit, we don't have a minimum_nan(A, dims)