More 1.21.9 Feature Updates #1168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This data field was removed in 1.21.5
misode
requested changes
Oct 13, 2025
Member
misode
left a comment
misode
left a comment
There was a problem hiding this comment.
We prefer backwards/negative overlays, for example backport_81. This makes it easier to remove these overlays in the future and ensures that the data folder is always the latest version.
gm4_metallurgy/since_88/data/gm4_metallurgy/function/init.mcfunction
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Oct 31, 2025
- Disassemblers was left as `since_88` as the contents are generated - Standard Crafting was left as `since_88` because inverting it is not easy without errors in prior versions
Metallurgy Expansions - Update `modeldata_registry` with copper
This comment was marked as outdated.
This comment was marked as outdated.
Merged
TheThanathor
approved these changes
Nov 1, 2025
Member
TheThanathor
left a comment
TheThanathor
left a comment
There was a problem hiding this comment.
Looks good! Left two comments but they're not really blocking anything
We should maybe look at updating Metallurgy at some point to also accept custom items or items with custom durability, but for now it's fine.
Comment on lines
+7
to
+8
| execute store result score $tool_max_damage gm4_ml_data run data get storage gm4_audere_shamir:temp/player/tool SelectedItem.components."minecraft:custom_data".MaxDurability | ||
| # | MaxDamage is set by gm4_moneo_shamir:store_maximum |
Member
There was a problem hiding this comment.
Does this mean Audere is now reliant on Moneo? While that's technically fine while Moneo is in base Metallurgy it might cause problems if Moneo is ever updated / removed since it's unlikely this would be thought of then
Contributor
Author
There was a problem hiding this comment.
Yes, although this is a change from #1167 which is only mixed in here because I needed to handle overlays of the same files for copper tools. We can definitely move the store_maximum function into the metallurgy namespace if needed though
| execute unless block ~ ~ ~ #gm4_crossbow_cartridges:torch run loot spawn ~ ~ ~ loot minecraft:blocks/copper_torch | ||
|
|
||
| # place block sound | ||
| playsound minecraft:block.wood.place block @a[distance=..15] |
Member
There was a problem hiding this comment.
Also for the other materials, but I feel like this shouldn't play if the torch didn't actually place
Contributor
Author
There was a problem hiding this comment.
Oh huh, yeah. Likely a change for a different PR though so I'll make an issue to track it
misode
approved these changes
Nov 3, 2025
EpyonProjects
pushed a commit
to EpyonProjects/GM4_Datapacks
that referenced
this pull request
Nov 20, 2025
* Remove deprecated `CanDuplicate` nbt from Gemini Shamir breed allay - This data field was removed in 1.21.5 * Add copper torch to Crossbow Cartridges * Metallurgy Copper Tools (not RP) * Replace `#gm4:boots` with `#minecraft:foot_armor` * Update `shamir_model_template.py` with copper * Adjust gold max damage + remove redundancy (Gamemode4Dev#1167) * Update overlays with gold arborenda PR changes * Swap most overlays to `backport_81` - Disassemblers was left as `since_88` as the contents are generated - Standard Crafting was left as `since_88` because inverting it is not easy without errors in prior versions * More resource pack stuff? * Update `modeldata_registry` with copper Metallurgy Expansions - Update `modeldata_registry` with copper
misode
added a commit
that referenced
this pull request
Nov 29, 2025
* Update beet and pack format * Update flash particle * Update chain -> icon_chain * Update noise router * Try to fix backwards plugin * Add min_format and max_format to overlays * runcows misc 1.21.9 commits (#1165) * Add copper weapons and armor to SR * Add copper golem to Reeling Rods * Disassembler copper tools and armor - untested overlay because beet is still broken * Update base tag lists * Add copper horse armor to Standard Crafting - overlay may be broken due to beet not being fully updated * Add mannequin to Reeling Rods steal_equipment * Lively Lily Pads 1.21.9 Feature Update (#1181) * Lively Lily Pads 1.21.9 * comments lie * Micro optimization * Metallurgy, desire lines, crossbow cartridges (#1168) * Remove deprecated `CanDuplicate` nbt from Gemini Shamir breed allay - This data field was removed in 1.21.5 * Add copper torch to Crossbow Cartridges * Metallurgy Copper Tools (not RP) * Replace `#gm4:boots` with `#minecraft:foot_armor` * Update `shamir_model_template.py` with copper * Adjust gold max damage + remove redundancy (#1167) * Update overlays with gold arborenda PR changes * Swap most overlays to `backport_81` - Disassemblers was left as `since_88` as the contents are generated - Standard Crafting was left as `since_88` because inverting it is not easy without errors in prior versions * More resource pack stuff? * Update `modeldata_registry` with copper Metallurgy Expansions - Update `modeldata_registry` with copper * Lightning in a Bottle 1.21.9 (#1188) * logic updating * attempt at connector textures + auto skin cache * Collapse overlay with block tags * Fix format fields for `beet dev` resource pack * [1.21.9] Fix overlay validation & beet (#1205) * Fix overlay validation by adding empty overlays * Update beet to 0.112.0 - Dev still broken * Readd empty space * Add 1.21.10 to supported (#1203) * Fix waterloggable tag order (#1202) * Fix (#1201) * Revert "Merge branch 'update-1.21.9' of https://github.com/Gamemode4Dev/GM4_Datapacks into update-1.21.9" This reverts commit 58097ab, reversing changes made to 6c297d2. * Revert "Merge remote-tracking branch 'upstream/master' into update-1.21.9" This reverts commit 6c297d2, reversing changes made to ccc5926. * Reapply "Merge remote-tracking branch 'upstream/master' into update-1.21.9" This reverts commit 93f767d. * Reapply "Merge branch 'update-1.21.9' of https://github.com/Gamemode4Dev/GM4_Datapacks into update-1.21.9" This reverts commit c790085. * Soul Glass - change recipe to normal furnace (#1211) * change recipe to use normal furnace * up module minor version * runcows comments * reduce desire line chance (#1212) * Vibro Shamir - use attributes (#1209) * let vibro use attributes note: this does not apply the safe fall distance from jump boost effect, but that is normally gone on landing anyway * add function header * Update packtest * Update beet to edayot's PR * Hex numbers are not supported by mecha yet * Update beet to fix worldgen in overlays * Fix metallurgy and lively lily pads overlays * Switch back to edayot's PR * Update beet to v0.112.1 * Make some failing tests optional --------- Co-authored-by: runcows <124551271+runcows@users.noreply.github.com> Co-authored-by: SpecialBuilder <specialbuilder32@gmail.com> Co-authored-by: Thanathor <73304324+TheThanathor@users.noreply.github.com>
github-actions bot
pushed a commit
that referenced
this pull request
Nov 29, 2025
* Update beet and pack format * Update flash particle * Update chain -> icon_chain * Update noise router * Try to fix backwards plugin * Add min_format and max_format to overlays * runcows misc 1.21.9 commits (#1165) * Add copper weapons and armor to SR * Add copper golem to Reeling Rods * Disassembler copper tools and armor - untested overlay because beet is still broken * Update base tag lists * Add copper horse armor to Standard Crafting - overlay may be broken due to beet not being fully updated * Add mannequin to Reeling Rods steal_equipment * Lively Lily Pads 1.21.9 Feature Update (#1181) * Lively Lily Pads 1.21.9 * comments lie * Micro optimization * Metallurgy, desire lines, crossbow cartridges (#1168) * Remove deprecated `CanDuplicate` nbt from Gemini Shamir breed allay - This data field was removed in 1.21.5 * Add copper torch to Crossbow Cartridges * Metallurgy Copper Tools (not RP) * Replace `#gm4:boots` with `#minecraft:foot_armor` * Update `shamir_model_template.py` with copper * Adjust gold max damage + remove redundancy (#1167) * Update overlays with gold arborenda PR changes * Swap most overlays to `backport_81` - Disassemblers was left as `since_88` as the contents are generated - Standard Crafting was left as `since_88` because inverting it is not easy without errors in prior versions * More resource pack stuff? * Update `modeldata_registry` with copper Metallurgy Expansions - Update `modeldata_registry` with copper * Lightning in a Bottle 1.21.9 (#1188) * logic updating * attempt at connector textures + auto skin cache * Collapse overlay with block tags * Fix format fields for `beet dev` resource pack * [1.21.9] Fix overlay validation & beet (#1205) * Fix overlay validation by adding empty overlays * Update beet to 0.112.0 - Dev still broken * Readd empty space * Add 1.21.10 to supported (#1203) * Fix waterloggable tag order (#1202) * Fix (#1201) * Revert "Merge branch 'update-1.21.9' of https://github.com/Gamemode4Dev/GM4_Datapacks into update-1.21.9" This reverts commit 58097ab, reversing changes made to 6c297d2. * Revert "Merge remote-tracking branch 'upstream/master' into update-1.21.9" This reverts commit 6c297d2, reversing changes made to ccc5926. * Reapply "Merge remote-tracking branch 'upstream/master' into update-1.21.9" This reverts commit 93f767d. * Reapply "Merge branch 'update-1.21.9' of https://github.com/Gamemode4Dev/GM4_Datapacks into update-1.21.9" This reverts commit c790085. * Soul Glass - change recipe to normal furnace (#1211) * change recipe to use normal furnace * up module minor version * runcows comments * reduce desire line chance (#1212) * Vibro Shamir - use attributes (#1209) * let vibro use attributes note: this does not apply the safe fall distance from jump boost effect, but that is normally gone on landing anyway * add function header * Update packtest * Update beet to edayot's PR * Hex numbers are not supported by mecha yet * Update beet to fix worldgen in overlays * Fix metallurgy and lively lily pads overlays * Switch back to edayot's PR * Update beet to v0.112.1 * Make some failing tests optional --------- Co-authored-by: runcows <124551271+runcows@users.noreply.github.com> Co-authored-by: SpecialBuilder <specialbuilder32@gmail.com> Co-authored-by: Thanathor <73304324+TheThanathor@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
CanDuplicatenbt field from Gemini Shamir, this field was removed in MC 1.21.5#gm4:bootswith#minecraft:foot_armorbackport_81since_88contents are generated) and Standard Crafting