Skip to content

Commit eaa6c61

Browse files
committed
Fixed bug with auction filtering order
1 parent bb8e16d commit eaa6c61

File tree

4 files changed

+14
-7
lines changed

4 files changed

+14
-7
lines changed

CHANGELOG.rst

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,16 @@ Changelog
66
Due to this library relying on external content, older versions are not guaranteed to work.
77
Try to always use the latest version.
88

9+
.. v3.5.3:
10+
11+
3.5.3 (2020-09-24)
12+
==================
13+
14+
- Fixed bug with ascending ordering (lowest / earliest) not being passed to the request URL.
15+
916
.. v3.5.2:
1017
11-
3.5.2 (2020-09-22)
18+
3.5.2 (2020-09-23)
1219
==================
1320

1421
- Fixed bug with auctions with more than 10 charms failing to parse.

serve.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,12 +52,12 @@ async def get_current_auctions(request: web.Request):
5252
filters.world = request.query.get("world")
5353
filters.battleye = try_enum(tibiapy.BattlEyeTypeFilter, request.query.get("battleye"))
5454
filters.pvp_type = try_enum(tibiapy.PvpTypeFilter, request.query.get("pvp_type"))
55-
filters.min_level = tibiapy.utils.parse_integer(request.query.get("min_level"))
56-
filters.max_level = tibiapy.utils.parse_integer(request.query.get("max_level"))
55+
filters.min_level = tibiapy.utils.parse_integer(request.query.get("min_level"), None)
56+
filters.max_level = tibiapy.utils.parse_integer(request.query.get("max_level"), None)
5757
filters.vocation = try_enum(tibiapy.VocationAuctionFilter, request.query.get("vocation"))
5858
filters.skill = try_enum(tibiapy.SkillFilter, request.query.get("skill"))
59-
filters.min_skill_level = tibiapy.utils.parse_integer(request.query.get("min_skill_level"))
60-
filters.max_skill_level = tibiapy.utils.parse_integer(request.query.get("max_skill_level"))
59+
filters.min_skill_level = tibiapy.utils.parse_integer(request.query.get("min_skill_level"), None)
60+
filters.max_skill_level = tibiapy.utils.parse_integer(request.query.get("max_skill_level"), None)
6161
filters.order_by = try_enum(tibiapy.AuctionOrderBy, request.query.get("order_by"))
6262
filters.order = try_enum(tibiapy.AuctionOrder, request.query.get("order"))
6363
filters.item = request.query.get("item")

tibiapy/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
__version__ = '3.5.2'
1+
__version__ = '3.5.3'
22
__author__ = 'Allan Galarza'
33

44
import logging

tibiapy/bazaar.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ def query_params(self):
172172
"searchstring": self.search_string,
173173
"searchtype": self.search_type.value if self.search_type else None,
174174
}
175-
return {k: v for k, v in params.items() if v}
175+
return {k: v for k, v in params.items() if v is not None}
176176

177177
@classmethod
178178
def _parse_filter_table(cls, table):

0 commit comments

Comments
 (0)