Merge pull request #39 from Galarzaa90/37-get_highscores_url-does-not-work-as-documented-and-breaks-when-no-vocation-is-sent

fix get_highscores_url not handling None values

Author: Galarzaa90

tests/tests_urls.py

@@ -0,0 +1,10 @@
+from tests.tests_tibiapy import TestCommons
+from tibiapy.urls import get_highscores_url
+
+
+class TestUrls(TestCommons):
+
+    def test_get_highscores_url_empty_params(self):
+        url = get_highscores_url()
+
+        self.assertEqual("https://www.tibia.com/community/?subtopic=highscores&currentpage=1", url)

tibiapy/urls.py

@@ -414,9 +414,13 @@ def get_highscores_url(
     """
     pvp_types = pvp_types or []
     pvp_params = [("worldtypes[]", p.value) for p in pvp_types]
-    return get_tibia_url("community", "highscores", *pvp_params, world=world, category=category.value,
-                         profession=vocation.value, currentpage=page,
-                         beprotection=battleye_type.value if battleye_type else None)
+    return get_tibia_url("community", "highscores", *pvp_params,
+                         world=world,
+                         category=category.value if category else None,
+                         profession=vocation.value if vocation else None,
+                         currentpage=page,
+                         beprotection=battleye_type.value if battleye_type else None,
+                         )
 
 
 def get_kill_statistics_url(world: str) -> str: