Skip to content

Commit 1cb37e2

Browse files
committed
Fixed URLS of players with special characters in their names
1 parent 429e018 commit 1cb37e2

File tree

3 files changed

+11
-4
lines changed

3 files changed

+11
-4
lines changed

CHANGELOG.rst

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,13 @@
22
Changelog
33
=========
44

5+
.. _v1.1.2:
6+
7+
1.1.2 (2019-01-22)
8+
==================
9+
10+
- Fixed TibiaData URLs of tibia characters with special characters in their names. (e.g Himmelhüpferin)
11+
512
.. _v1.1.1:
613

714
1.1.1 (2019-01-09)

tibiapy/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,4 @@
77
from tibiapy.house import *
88
from tibiapy.world import *
99

10-
__version__ = '1.1.1'
10+
__version__ = '1.1.2'

tibiapy/abc.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ def get_url_tibiadata(cls, name):
153153
--------
154154
:class:`str`
155155
The URL to the character's page on TibiaData.com."""
156-
return CHARACTER_URL_TIBIADATA % urllib.parse.quote(name.encode('iso-8859-1'))
156+
return CHARACTER_URL_TIBIADATA % urllib.parse.quote(name)
157157

158158

159159
class BaseGuild(Serializable, metaclass=abc.ABCMeta):
@@ -212,7 +212,7 @@ def get_url_tibiadata(cls, name):
212212
--------
213213
:class:`str`
214214
The URL to the guild's page on TibiaData.com."""
215-
return GUILD_URL_TIBIADATA % urllib.parse.quote(name.encode('iso-8859-1'))
215+
return GUILD_URL_TIBIADATA % urllib.parse.quote(name)
216216

217217

218218
class BaseHouse(Serializable, metaclass=abc.ABCMeta):
@@ -397,4 +397,4 @@ def get_url_tibiadata(cls, name):
397397
:class:`str`
398398
The URL to the world's information page on TibiaData.com.
399399
"""
400-
return WORLD_URL_TIBIADATA % name.title()
400+
return WORLD_URL_TIBIADATA % name.title()

0 commit comments

Comments
 (0)