Skip to content

Commit 15ea76a

Browse files
committed
bug(dspy): Added comments
1 parent d6e08de commit 15ea76a

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

dsp/modules/hf_client.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -155,8 +155,9 @@ def _generate(self, prompt, **kwargs):
155155
if system_prompt:
156156
messages.insert(0, {"role": "system", "content": system_prompt})
157157

158-
kwargs.pop("port","False")
159-
kwargs.pop("url","False")
158+
# Popping extra paramters for vLLM basemodel requirements (#974: https://github.com/stanfordnlp/dspy/issues/974)
159+
kwargs.pop("port",None)
160+
kwargs.pop("url",None)
160161

161162
payload = {
162163
"model": self.kwargs["model"],
@@ -184,8 +185,9 @@ def _generate(self, prompt, **kwargs):
184185
print("Failed to parse JSON response:", response.text)
185186
raise Exception("Received invalid JSON response from server")
186187
else:
187-
kwargs.pop("port","False")
188-
kwargs.pop("url","False")
188+
# Popping extra paramters for vLLM basemodel requirements (#974: https://github.com/stanfordnlp/dspy/issues/974)
189+
kwargs.pop("port",None)
190+
kwargs.pop("url",None)
189191

190192
payload = {
191193
"model": self.kwargs["model"],

0 commit comments

Comments
 (0)