clean up programs etc related to regrid.pl #1057
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ake-v12' into feature/sdrabenh/gcm_v12-rc1
…into feature/sdrabenh/gcm_v12-rc1
…into feature/sdrabenh/gcm_v12-rc1
As we move to FMS in Baselibs, we shouldn't use the old `fms_r4` and `fms_r8` targets anymore as they are non-standard. Instead we move to `FMS::fms_r4` and `FMS::fms_r8`.
…ate-fms-cmake-target
…into feature/sdrabenh/gcm_v12
…into feature/sdrabenh/gcm_v12
…fms-cmake-target-v12
Conditional is now consistent with v12 branch
… into feature/sdrabenh/gcm_v12
…feature/sdrabenh/gcm_v12
… into feature/sdrabenh/gcm_v12
… into feature/sdrabenh/gcm_v12
… into feature/sdrabenh/gcm_v12
Member
|
@gmao-rreichle Would you like me to make a GEOSgcm v11 variant of GEOS-ESM/GEOS_Util#113 I mean, I feel fine removing As long as @sdrabenh is fine doing so as well. |
zhaobin74
approved these changes
Sep 10, 2025
Contributor
zhaobin74
left a comment
zhaobin74
left a comment
There was a problem hiding this comment.
No problem with 0-diff.
Contributor
Author
|
@mathomp4 : These changes are meant to go into develop after develop has become the base for v12. The v11 model is still meant to support regrid.pl. Personally, I would have been ok with removing regrid.pl sooner, but as a group we decided to keep regrid.pl in v11. |
Contributor
Author
|
@sdrabenh , @mathomp4 : Ouch, I probably messed up the present PR in my rush to get a new PR that goes into the v12 branch (#1157). Here's what I did:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up programs, scripts, etc related to obsolete regrid.pl (replaced with remap_restarts.py in GEOS_Util repo)
Initial commit removes mk_GEOSldasRestarts.F90
More cleanup is probably needed.
Related PRs:
GEOS-ESM/GEOS_Util#113 (pointing to GCM v12 feature branch)
cc: @mathomp4 @weiyuan-jiang @biljanaorescanin