Skip to content

Fix file saving when file size is reduced #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Fix file saving when file size is reduced #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion gcodeworkshop/src/document.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,14 +206,18 @@ bool Document::saveFile(const QString& filePath)
QFile file(filePath);
m_ioErrorString.clear();

// WARNING: If opened in QIODevice::ReadOnly mode, a false positive in QFileSystemWatcher
// WARNING: If opened in QIODevice::WriteOnly mode, a false positive in QFileSystemWatcher
// occurs after writing and closing. This is correct for Windows 7.
// Update: it is possible that when opening a file with this flag, Windows
// immediately truncates the file size to zero and this happens before
// disabling monitoring in the code below.
if (!file.open(QIODevice::ReadWrite)) {
m_ioErrorString = file.errorString();
return false;
}

fileWatchStop();
file.resize(0);
file.write(rawData());
file.close();
fileWatchStart(filePath);
Expand Down
Loading