test: checkCommitMessages and lint/reformat

Author: jescalada

test/processors/blockForAuth.test.js

@@ -1,13 +1,16 @@
-const { expect } = require('chai');
+const chai = require('chai');
 const sinon = require('sinon');
 const proxyquire = require('proxyquire').noCallThru();
 const { Step } = require('../../src/proxy/actions');
 
-describe('blockForAuth.exec', () => {
-  let req;
+chai.should();
+const expect = chai.expect;
+
+describe('blockForAuth', () => {
   let action;
-  let getServiceUIURLStub;
   let exec;
+  let getServiceUIURLStub;
+  let req;
   let stepInstance;
   let StepSpy;
 
@@ -24,65 +27,70 @@ describe('blockForAuth.exec', () => {
 
     stepInstance = new Step('temp');
     sinon.stub(stepInstance, 'setAsyncBlock');
-    
+
     StepSpy = sinon.stub().returns(stepInstance);
 
     getServiceUIURLStub = sinon.stub().returns('http://localhost:8080');
-    
-    ({ exec } = proxyquire('../../src/proxy/processors/push-action/blockForAuth', {
+
+    const blockForAuth = proxyquire('../../src/proxy/processors/push-action/blockForAuth', {
       '../../../service/urls': { getServiceUIURL: getServiceUIURLStub },
       '../../actions': { Step: StepSpy }
-    }));
+    });
+
+    exec = blockForAuth.exec;
   });
 
   afterEach(() => {
     sinon.restore();
   });
 
-  it('should generate a correct shareable URL', async () => {
-    await exec(req, action);
-    expect(getServiceUIURLStub.calledOnce).to.be.true;
-    expect(getServiceUIURLStub.calledWithExactly(req)).to.be.true;
-  });
+  describe('exec', () => {
 
-  it('should create step with correct parameters', async () => {
-    await exec(req, action);
-    
-    expect(StepSpy.calledOnce).to.be.true;
-    expect(StepSpy.calledWithExactly('authBlock')).to.be.true;
-    expect(stepInstance.setAsyncBlock.calledOnce).to.be.true;
-    
-    const message = stepInstance.setAsyncBlock.firstCall.args[0];
-    expect(message).to.include('http://localhost:8080/dashboard/push/push_123');
-    expect(message).to.include('\x1B[32mGitProxy has received your push ✅\x1B[0m');
-    expect(message).to.include('\x1B[34mhttp://localhost:8080/dashboard/push/push_123\x1B[0m');
-    expect(message).to.include('🔗 Shareable Link');
-  });
+    it('should generate a correct shareable URL', async () => {
+      await exec(req, action);
+      expect(getServiceUIURLStub.calledOnce).to.be.true;
+      expect(getServiceUIURLStub.calledWithExactly(req)).to.be.true;
+    });
 
-  it('should add step to action exactly once', async () => {
-    await exec(req, action);
-    expect(action.addStep.calledOnce).to.be.true;
-    expect(action.addStep.calledWithExactly(stepInstance)).to.be.true;
-  });
+    it('should create step with correct parameters', async () => {
+      await exec(req, action);
 
-  it('should return action instance', async () => {
-    const result = await exec(req, action);
-    expect(result).to.equal(action);
-  });
+      expect(StepSpy.calledOnce).to.be.true;
+      expect(StepSpy.calledWithExactly('authBlock')).to.be.true;
+      expect(stepInstance.setAsyncBlock.calledOnce).to.be.true;
 
-  it('should handle https URL format', async () => {
-    getServiceUIURLStub.returns('https://git-proxy-hosted-ui.com');
-    await exec(req, action);
-    
-    const message = stepInstance.setAsyncBlock.firstCall.args[0];
-    expect(message).to.include('https://git-proxy-hosted-ui.com/dashboard/push/push_123');
-  });
+      const message = stepInstance.setAsyncBlock.firstCall.args[0];
+      expect(message).to.include('http://localhost:8080/dashboard/push/push_123');
+      expect(message).to.include('\x1B[32mGitProxy has received your push ✅\x1B[0m');
+      expect(message).to.include('\x1B[34mhttp://localhost:8080/dashboard/push/push_123\x1B[0m');
+      expect(message).to.include('🔗 Shareable Link');
+    });
+
+    it('should add step to action exactly once', async () => {
+      await exec(req, action);
+      expect(action.addStep.calledOnce).to.be.true;
+      expect(action.addStep.calledWithExactly(stepInstance)).to.be.true;
+    });
+
+    it('should return action instance', async () => {
+      const result = await exec(req, action);
+      expect(result).to.equal(action);
+    });
+
+    it('should handle https URL format', async () => {
+      getServiceUIURLStub.returns('https://git-proxy-hosted-ui.com');
+      await exec(req, action);
+
+      const message = stepInstance.setAsyncBlock.firstCall.args[0];
+      expect(message).to.include('https://git-proxy-hosted-ui.com/dashboard/push/push_123');
+    });
+
+    it('should handle special characters in action ID', async () => {
+      action.id = 'push@special#chars!';
+      await exec(req, action);
 
-  it('should handle special characters in action ID', async () => {
-    action.id = 'push@special#chars!';
-    await exec(req, action);
-    
-    const message = stepInstance.setAsyncBlock.firstCall.args[0];
-    expect(message).to.include('/push/push@special#chars!');
+      const message = stepInstance.setAsyncBlock.firstCall.args[0];
+      expect(message).to.include('/push/push@special#chars!');
+    });
   });
 });