chore: reject none clone urls

Author: andypols

src/db/file/repo.ts

@@ -52,7 +52,7 @@ export const getRepo = async (name: string) => {
 
 export const getRepoByUrl = async (url: string) => {
   return new Promise<Repo | null>((resolve, reject) => {
-    db.findOne({ url: url.toLowerCase().replace('.git', '') }, (err: Error | null, doc: Repo) => {
+    db.findOne({ url: url.toLowerCase() }, (err: Error | null, doc: Repo) => {
       // ignore for code coverage as neDB rarely returns errors even for an invalid query
       /* istanbul ignore if */
       if (err) {

src/db/mongo/repo.ts

@@ -19,9 +19,8 @@ export const getRepo = async (name: string) => {
 };
 
 export const getRepoByUrl = async (url: string) => {
-  url = url.toLowerCase().replace('.git', '');
   const collection = await connect(collectionName);
-  return collection.findOne({ url: { $eq: url } });
+  return collection.findOne({ url: { $eq: url.toLowerCase() } });
 };
 
 export const createRepo = async (repo: Repo) => {

test/db/file/repo.test.js

@@ -18,7 +18,7 @@ describe('File DB', () => {
       const repoData = {
         name: 'sample',
         users: { canPush: [] },
-        url: 'http://example.com/sample-repo',
+        url: 'http://example.com/sample-repo.git',
       };
 
       sandbox.stub(repoModule.db, 'findOne').callsFake((query, cb) => cb(null, repoData));
@@ -33,27 +33,27 @@ describe('File DB', () => {
       const repoData = {
         name: 'sample',
         users: { canPush: [] },
-        url: 'https://github.com/finos/git-proxy',
+        url: 'https://github.com/finos/git-proxy.git',
       };
 
       sandbox.stub(repoModule.db, 'findOne').callsFake((query, cb) => cb(null, repoData));
 
-      const result = await repoModule.getRepoByUrl('https://github.com/finos/git-proxy');
+      const result = await repoModule.getRepoByUrl('https://github.com/finos/git-proxy.git');
       expect(result).to.equal(repoData);
     });
 
     it('should get the repo using the url, stripping off the .git', async () => {
       const repoData = {
         name: 'sample',
         users: { canPush: [] },
-        url: 'https://github.com/finos/git-proxy',
+        url: 'https://github.com/finos/git-proxy.git',
       };
 
       sandbox.stub(repoModule.db, 'findOne').callsFake((query, cb) => cb(null, repoData));
 
       const result = await repoModule.getRepoByUrl('https://github.com/finos/git-proxy.git');
 
-      expect(repoModule.db.findOne.calledWith(sinon.match({ url: 'https://github.com/finos/git-proxy'}))).to.be.true;
+      expect(repoModule.db.findOne.calledWith(sinon.match({ url: 'https://github.com/finos/git-proxy.git'}))).to.be.true;
       expect(result).to.equal(repoData);
     });
   });

test/db/mongo/repo.test.js

@@ -22,7 +22,7 @@ describe('MongoDB', () => {
       const repoData = {
         name: 'sample',
         users: { canPush: [] },
-        url: 'http://example.com/sample-repo',
+        url: 'http://example.com/sample-repo.git',
       };
       repoCollection.findOne.resolves(repoData);
 
@@ -38,47 +38,31 @@ describe('MongoDB', () => {
       const repoData = {
         name: 'sample',
         users: { canPush: [] },
-        url: 'https://github.com/finos/git-proxy',
-      };
-      repoCollection.findOne.resolves(repoData);
-
-      const result = await getRepoByUrl('https://github.com/finos/git-proxy');
-      expect(result).to.equal(repoData);
-      expect(connectionStub.calledWith('repos')).to.be.true;
-      expect(
-        repoCollection.findOne.calledWith({ url: { $eq: 'https://github.com/finos/git-proxy' } }),
-      ).to.be.true;
-    });
-
-    it('should get the repo using the url, stripping off the .git', async () => {
-      const repoData = {
-        name: 'sample',
-        users: { canPush: [] },
-        url: 'https://github.com/finos/git-proxy',
+        url: 'https://github.com/finos/git-proxy.git',
       };
       repoCollection.findOne.resolves(repoData);
 
       const result = await getRepoByUrl('https://github.com/finos/git-proxy.git');
       expect(result).to.equal(repoData);
       expect(connectionStub.calledWith('repos')).to.be.true;
       expect(
-        repoCollection.findOne.calledWith({ url: { $eq: 'https://github.com/finos/git-proxy' } }),
+        repoCollection.findOne.calledWith({ url: { $eq: 'https://github.com/finos/git-proxy.git' } }),
       ).to.be.true;
     });
 
     it('should get the repo using the url, ignoring the case', async () => {
       const repoData = {
         name: 'sample',
         users: { canPush: [] },
-        url: 'https://github.com/finos/git-proxy',
+        url: 'https://github.com/finos/git-proxy.git',
       };
       repoCollection.findOne.resolves(repoData);
 
       const result = await getRepoByUrl('https://github.com/Finos/Git-Proxy.git');
       expect(result).to.equal(repoData);
       expect(connectionStub.calledWith('repos')).to.be.true;
       expect(
-        repoCollection.findOne.calledWith({ url: { $eq: 'https://github.com/finos/git-proxy' } }),
+        repoCollection.findOne.calledWith({ url: { $eq: 'https://github.com/finos/git-proxy.git' } }),
       ).to.be.true;
     });
   });