fix: refactor problematic checks (undefined commiter, user)

Author: jescalada

src/proxy/processors/push-action/checkUserPushPermission.ts

@@ -4,10 +4,29 @@ import { getUsers, isUserPushAllowed } from '../../../db';
 // Execute if the repo is approved
 const exec = async (req: any, action: Action): Promise<Action> => {
   const step = new Step('checkUserPushPermission');
+  const user = action.user;
 
+  if (!user) {
+    step.log('Action has no user set. This may be due to a fast-forward ref update. Deferring to getMissingData action.');
+    action.addStep(step);
+    return action;
+  }
+
+  return await validateUser(user, action, step);
+};
+
+/**
+ * Helper that validates the user's push permission.
+ * This can be used by other actions that need it. For example, when the user is missing from the commit data,
+ * validation is deferred to getMissingData, but the logic is the same.
+ * @param {string} user The user to validate
+ * @param {Action} action The action object
+ * @param {Step} step The step object
+ * @return {Promise<Action>} The action object
+ */
+const validateUser = async (user: string, action: Action, step: Step): Promise<Action> => { 
   const repoName = action.repo.split('/')[1].replace('.git', '');
   let isUserAllowed = false;
-  let user = action.user;
 
   // Find the user associated with this Git Account
   const list = await getUsers({ gitAccount: action.user });
@@ -44,4 +63,4 @@ const exec = async (req: any, action: Action): Promise<Action> => {
 
 exec.displayName = 'checkUserPushPermission.exec';
 
-export { exec };
+export { exec, validateUser };

src/proxy/processors/push-action/parsePush.ts

@@ -1,17 +1,9 @@
 import { Action, Step } from '../../actions';
 import zlib from 'zlib';
-import fs from 'fs';
-import path from 'path';
 import lod from 'lodash';
 import { CommitContent } from '../types';
 const BitMask = require('bit-mask') as any;
 
-const dir = path.resolve(__dirname, './.tmp');
-
-if (!fs.existsSync(dir)) {
-  fs.mkdirSync(dir, { recursive: true });
-}
-
 /**
  * Executes the parsing of a push request.
  * @param {*} req - The request object containing the push data.
@@ -29,7 +21,6 @@ async function exec(req: any, action: Action): Promise<Action> {
       return action;
     }
     const [packetLines, packDataOffset] = parsePacketLines(req.body);
-
     const refUpdates = packetLines.filter((line) => line.includes('refs/heads/'));
 
     if (refUpdates.length !== 1) {
@@ -68,15 +59,16 @@ async function exec(req: any, action: Action): Promise<Action> {
     const contents = getContents(contentBuff as any, meta.entries as number);
 
     action.commitData = getCommitData(contents as any);
-
-    if (action.commitFrom === '0000000000000000000000000000000000000000') {
-      action.commitFrom = action.commitData[action.commitData.length - 1].parent;
+    if (action.commitData.length === 0) {
+      step.log('No commit data found when parsing push.')
+    } else {
+      if (action.commitFrom === '0000000000000000000000000000000000000000') {
+        action.commitFrom = action.commitData[action.commitData.length - 1].parent;
+      }
+      const user = action.commitData[action.commitData.length - 1].committer;
+      action.user = user;  
     }
 
-    const user = action.commitData[action.commitData.length - 1].committer;
-    console.log(`Push Request received from user ${user}`);
-    action.user = user;
-
     step.content = {
       meta: meta,
     };
@@ -235,6 +227,7 @@ const getContents = (buffer: Buffer | CommitContent[], entries: number) => {
   for (let i = 0; i < entries; i++) {
     try {
       const [content, nextBuffer] = getContent(i, buffer as Buffer);
+      console.log({ content, nextBuffer });
       buffer = nextBuffer as Buffer;
       contents.push(content);
     } catch (e) {