feat: test auto rejection

Author: fabiovincenzi

test/chain.test.js

@@ -253,7 +253,7 @@ describe('proxy chain', function () {
       type: 'push',
       continue: () => true,
       allowPush: false,
-      setAllowAutoApprover: sinon.stub(),
+      setAutoApproval: sinon.stub(),
       repoName: 'test-repo',
       commitTo: 'newCommitHash',
       autoApproved: false,

test/preReceive/preReceive.test.js

@@ -19,26 +19,15 @@ describe('Pre-Receive Hook Execution', function () {
       addStep: function (step) {
         this.steps.push(step);
       },
-      setAllowAutoApprover: sinon.stub(),
+      setAutoApproval: sinon.stub(),
+      setAutoRejection: sinon.stub(),
     };
   });
 
   afterEach(() => {
     sinon.restore();
   });
 
-  it('should execute hook successfully and require manual approval', async () => {
-    const scriptPath = path.resolve(__dirname, 'pre-receive-hooks/always-exit-1.sh');
-
-    const result = await exec(req, action, scriptPath);
-
-    expect(result.steps).to.have.lengthOf(1);
-    expect(result.steps[0].error).to.be.false;
-    expect(result.steps[0].logs.some((log) => log.includes('Push requires manual approval.'))).to.be
-      .true;
-    expect(action.setAllowAutoApprover.called).to.be.false;
-  });
-
   it('should skip execution when hook file does not exist', async () => {
     const scriptPath = path.resolve(__dirname, 'pre-receive-hooks/missing-hook.sh');
 
@@ -51,7 +40,8 @@ describe('Pre-Receive Hook Execution', function () {
         log.includes('Pre-receive hook not found, skipping execution.'),
       ),
     ).to.be.true;
-    expect(action.setAllowAutoApprover.called).to.be.false;
+    expect(action.setAutoApproval.called).to.be.false;
+    expect(action.setAutoRejection.called).to.be.false;
   });
 
   it('should skip execution when hook directory does not exist', async () => {
@@ -66,30 +56,12 @@ describe('Pre-Receive Hook Execution', function () {
         log.includes('Pre-receive hook not found, skipping execution.'),
       ),
     ).to.be.true;
-    expect(action.setAllowAutoApprover.called).to.be.false;
-  });
-
-  it('should fail when hook execution returns an error', async () => {
-    const scriptPath = path.resolve(__dirname, 'pre-receive-hooks/always-reject.sh');
-
-    const result = await exec(req, action, scriptPath);
-
-    expect(result.steps).to.have.lengthOf(1);
-
-    const step = result.steps[0];
-
-    expect(step.error).to.be.true;
-    expect(step.logs.some((log) => log.includes('Push rejected by pre-receive hook.'))).to.be.true;
-    expect(step.logs.some((log) => log.includes('Hook stderr:'))).to.be.true;
-
-    expect(step.errorMessage).to.exist;
-
-    expect(action.steps).to.deep.include(step);
-    expect(action.setAllowAutoApprover.called).to.be.false;
+    expect(action.setAutoApproval.called).to.be.false;
+    expect(action.setAutoRejection.called).to.be.false;
   });
 
   it('should catch and handle unexpected errors', async () => {
-    const scriptPath = path.resolve(__dirname, 'pre-receive-hooks/always-allow.sh');
+    const scriptPath = path.resolve(__dirname, 'pre-receive-hooks/always-exit-0.sh');
 
     sinon.stub(require('fs'), 'existsSync').throws(new Error('Unexpected FS error'));
 
@@ -100,11 +72,12 @@ describe('Pre-Receive Hook Execution', function () {
     expect(
       result.steps[0].logs.some((log) => log.includes('Hook execution error: Unexpected FS error')),
     ).to.be.true;
-    expect(action.setAllowAutoApprover.called).to.be.false;
+    expect(action.setAutoApproval.called).to.be.false;
+    expect(action.setAutoRejection.called).to.be.false;
   });
 
   it('should approve push automatically when hook returns status 0', async () => {
-    const scriptPath = path.resolve(__dirname, 'pre-receive-hooks/always-allow.sh');
+    const scriptPath = path.resolve(__dirname, 'pre-receive-hooks/always-exit-0.sh');
 
     const result = await exec(req, action, scriptPath);
 
@@ -115,6 +88,36 @@ describe('Pre-Receive Hook Execution', function () {
         log.includes('Push automatically approved by pre-receive hook.'),
       ),
     ).to.be.true;
-    expect(action.setAllowAutoApprover.calledOnce).to.be.true;
+    expect(action.setAutoApproval.calledOnce).to.be.true;
+    expect(action.setAutoRejection.called).to.be.false;
+  });
+
+  it('should reject push automatically when hook returns status 1', async () => {
+    const scriptPath = path.resolve(__dirname, 'pre-receive-hooks/always-exit-1.sh');
+
+    const result = await exec(req, action, scriptPath);
+
+    expect(result.steps).to.have.lengthOf(1);
+    expect(result.steps[0].error).to.be.false;
+    expect(
+      result.steps[0].logs.some((log) =>
+        log.includes('Push automatically rejected by pre-receive hook.'),
+      ),
+    ).to.be.true;
+    expect(action.setAutoRejection.calledOnce).to.be.true;
+    expect(action.setAutoApproval.called).to.be.false;
+  });
+
+  it('should execute hook successfully and require manual approval', async () => {
+    const scriptPath = path.resolve(__dirname, 'pre-receive-hooks/always-exit-2.sh');
+
+    const result = await exec(req, action, scriptPath);
+
+    expect(result.steps).to.have.lengthOf(1);
+    expect(result.steps[0].error).to.be.false;
+    expect(result.steps[0].logs.some((log) => log.includes('Push requires manual approval.'))).to.be
+      .true;
+    expect(action.setAutoApproval.called).to.be.false;
+    expect(action.setAutoRejection.called).to.be.false;
   });
 });