chore: update tests

Author: andypols

src/proxy/processors/push-action/checkRepoInAuthorisedList.ts

@@ -7,11 +7,11 @@ const exec = async (req: any, action: Action): Promise<Action> => {
 
   const found = (await getRepoByUrl(action.url)) !== null;
   if (found) {
-    step.log(`repo ${action.repo} is in the authorisedList`);
+    step.log(`repo ${action.url} is in the authorisedList`);
   } else {
     step.error = true;
-    step.log(`repo ${action.repo} is not in the authorised whitelist, ending`);
-    step.setError(`Rejecting repo ${action.repo} not in the authorised whitelist`);
+    step.log(`repo ${action.url} is not in the authorised whitelist, ending`);
+    step.setError(`Rejecting repo ${action.url} not in the authorised whitelist`);
   }
 
   action.addStep(step);

test/db/file/repo.test.js

@@ -24,7 +24,7 @@ describe('File DB', () => {
       sandbox.stub(repoModule.db, 'findOne').callsFake((query, cb) => cb(null, repoData));
 
       const result = await repoModule.getRepo('Sample');
-      expect(result).to.equal(repoData);
+      expect(result).to.deep.equal(repoData);
     });
   });
 
@@ -39,7 +39,7 @@ describe('File DB', () => {
       sandbox.stub(repoModule.db, 'findOne').callsFake((query, cb) => cb(null, repoData));
 
       const result = await repoModule.getRepoByUrl('https://github.com/finos/git-proxy.git');
-      expect(result).to.equal(repoData);
+      expect(result).to.deep.equal(repoData);
     });
 
     it('should get the repo using the url, stripping off the .git', async () => {
@@ -53,36 +53,29 @@ describe('File DB', () => {
 
       const result = await repoModule.getRepoByUrl('https://github.com/finos/git-proxy.git');
 
-      expect(repoModule.db.findOne.calledWith(sinon.match({ url: 'https://github.com/finos/git-proxy.git'}))).to.be.true;
-      expect(result).to.equal(repoData);
-    });
-    
-    it('should get the repo using the url, ignoring the case', async () => {
-      const repoData = {
-        name: 'sample',
-        users: { canPush: [] },
-        url: 'https://github.com/finos/git-proxy.git',
-      };
-
-      sandbox.stub(repoModule.db, 'findOne').callsFake((query, cb) => cb(null, repoData));
-
-      const result = await repoModule.getRepoByUrl('https://github.com/Finos/Git-Proxy.git');
-      expect(result).to.equal(repoData);
-      expect(repoModule.db.findOne.calledWith(sinon.match({ url: 'https://github.com/finos/git-proxy.git' }))).to.be.true;
+      expect(
+        repoModule.db.findOne.calledWith(
+          sinon.match({ url: 'https://github.com/finos/git-proxy.git' }),
+        ),
+      ).to.be.true;
+      expect(result).to.deep.equal(repoData);
     });
 
     it('should return null if the repo is not found', async () => {
       sandbox.stub(repoModule.db, 'findOne').callsFake((query, cb) => cb(null, null));
 
       const result = await repoModule.getRepoByUrl('https://github.com/finos/missing-repo.git');
       expect(result).to.be.null;
-      expect(repoModule.db.findOne.calledWith(sinon.match({ url: 'https://github.com/finos/missing-repo.git' })),
+      expect(
+        repoModule.db.findOne.calledWith(
+          sinon.match({ url: 'https://github.com/finos/missing-repo.git' }),
+        ),
       ).to.be.true;
     });
 
     it('should reject if the database returns an error', async () => {
       sandbox.stub(repoModule.db, 'findOne').callsFake((query, cb) => cb(new Error('DB error')));
-    
+
       try {
         await repoModule.getRepoByUrl('https://github.com/finos/git-proxy.git');
         expect.fail('Expected promise to be rejected');

test/db/mongo/repo.test.js

@@ -27,7 +27,7 @@ describe('MongoDB', () => {
       repoCollection.findOne.resolves(repoData);
 
       const result = await getRepo('Sample');
-      expect(result).to.equal(repoData);
+      expect(result).to.deep.equal(repoData);
       expect(connectionStub.calledWith('repos')).to.be.true;
       expect(repoCollection.findOne.calledWith({ name: { $eq: 'sample' } })).to.be.true;
     });
@@ -43,26 +43,12 @@ describe('MongoDB', () => {
       repoCollection.findOne.resolves(repoData);
 
       const result = await getRepoByUrl('https://github.com/finos/git-proxy.git');
-      expect(result).to.equal(repoData);
+      expect(result).to.deep.equal(repoData);
       expect(connectionStub.calledWith('repos')).to.be.true;
       expect(
-        repoCollection.findOne.calledWith({ url: { $eq: 'https://github.com/finos/git-proxy.git' } }),
-      ).to.be.true;
-    });
-
-    it('should get the repo using the url, ignoring the case', async () => {
-      const repoData = {
-        name: 'sample',
-        users: { canPush: [] },
-        url: 'https://github.com/finos/git-proxy.git',
-      };
-      repoCollection.findOne.resolves(repoData);
-
-      const result = await getRepoByUrl('https://github.com/Finos/Git-Proxy.git');
-      expect(result).to.equal(repoData);
-      expect(connectionStub.calledWith('repos')).to.be.true;
-      expect(
-        repoCollection.findOne.calledWith({ url: { $eq: 'https://github.com/finos/git-proxy.git' } }),
+        repoCollection.findOne.calledWith({
+          url: { $eq: 'https://github.com/finos/git-proxy.git' },
+        }),
       ).to.be.true;
     });
   });