fix: remove string values from ignorePatterns if they exist

Author: G-Rath

src/rules/utils.ts

@@ -50,6 +50,24 @@ const compileConfigCode = (fileCode: string): ESLint.Linter.Config => {
 const createCliEngineCache = new Map<string, ESLint.CLIEngine>();
 
 const createCLIEngine = (config: ESLint.Linter.Config): ESLint.CLIEngine => {
+  const extraConfig: ESLint.Linter.Config = {
+    parserOptions: {
+      ...config.parserOptions,
+      project: require.resolve('../../tsconfig.fake.json'),
+      projectFolderIgnoreList: []
+    }
+  };
+
+  if (config.ignorePatterns) {
+    const patterns = Array.isArray(config.ignorePatterns)
+      ? config.ignorePatterns
+      : [config.ignorePatterns];
+
+    extraConfig.ignorePatterns = patterns.filter(
+      pattern => typeof pattern !== 'string'
+    );
+  }
+
   return getsertCache(
     createCliEngineCache,
     JSON.stringify(config),
@@ -62,11 +80,7 @@ const createCLIEngine = (config: ESLint.Linter.Config): ESLint.CLIEngine => {
         envs: ['node'],
         baseConfig: {
           ...config,
-          parserOptions: {
-            ...config.parserOptions,
-            project: require.resolve('../../tsconfig.fake.json'),
-            projectFolderIgnoreList: []
-          }
+          ...extraConfig
         }
       }),
     'createCLIEngine'

test/src/rules/no-invalid-config.spec.ts

@@ -26,6 +26,8 @@ ruleTester.run('no-invalid-config', rule, {
   valid: [
     'module.exports = undefined;',
     'module.exports = "";',
+    'module.exports = { ignorePatterns: ["node_modules/"] }',
+    'module.exports = { ignorePatterns: "node_modules/" }',
     dedent`
       const { files } = require('./package.json');
 
@@ -748,6 +750,21 @@ ruleTester.run('InvalidConfig', rule, {
           column: 1
         })
       ]
+    },
+    {
+      code: 'module.exports = { ignorePatterns: [1] }',
+      errors: [
+        expectedError({
+          type: ESLintErrorType.InvalidConfig,
+          reason: [
+            '\n\t- Property "ignorePatterns" is the wrong type (expected string but got `[1]`).',
+            '\n\t- Property "ignorePatterns[0]" is the wrong type (expected string but got `1`).',
+            '\n\t- "ignorePatterns" should match exactly one schema in oneOf. Value: [1].'
+          ].join(''),
+          line: 1,
+          column: 1
+        })
+      ]
     }
   ]
 });