re-factor to decouple logging better.

Author: robotdan

src/main/java/io/fusionauth/http/server/DefaultHTTPUnexpectedExceptionHandler.java

@@ -24,11 +24,15 @@
  * @author Daniel DeGroff
  */
 public class DefaultHTTPUnexpectedExceptionHandler implements HTTPUnexpectedExceptionHandler {
+  private final Logger logger;
+
+  public DefaultHTTPUnexpectedExceptionHandler(LoggerFactory loggerFactory) {
+    this.logger = loggerFactory.getLogger(DefaultHTTPUnexpectedExceptionHandler.class);
+  }
 
   @Override
-  public int handle(LoggerFactory loggerFactory, Throwable t) {
+  public int handle(Throwable t) {
     int internalServerError = 500;
-    Logger logger = loggerFactory.getLogger(DefaultHTTPUnexpectedExceptionHandler.class);
     logger.error(String.format("[%s] Closing socket with status [%d]. An HTTP worker threw an exception while processing a request.", Thread.currentThread().threadId(), internalServerError), t);
     return internalServerError;
   }

src/main/java/io/fusionauth/http/server/HTTPServerConfiguration.java

@@ -79,7 +79,7 @@ public class HTTPServerConfiguration implements Configurable<HTTPServerConfigura
 
   private Duration shutdownDuration = Duration.ofSeconds(10);
 
-  private HTTPUnexpectedExceptionHandler unexpectedExceptionHandler = new DefaultHTTPUnexpectedExceptionHandler();
+  private HTTPUnexpectedExceptionHandler unexpectedExceptionHandler;
 
   private Duration writeThroughputCalculationDelayDuration = Duration.ofSeconds(5);
 
@@ -281,6 +281,11 @@ public Duration getShutdownDuration() {
    * @return The HTTP unexpected exception handler for this server. Never null.
    */
   public HTTPUnexpectedExceptionHandler getUnexpectedExceptionHandler() {
+    // Lazily construct a default so we can use the configured loggerFactory.
+    if (unexpectedExceptionHandler == null) {
+      unexpectedExceptionHandler = new DefaultHTTPUnexpectedExceptionHandler(loggerFactory);
+    }
+
     return unexpectedExceptionHandler;
   }
 

src/main/java/io/fusionauth/http/server/HTTPUnexpectedExceptionHandler.java

@@ -15,8 +15,6 @@
  */
 package io.fusionauth.http.server;
 
-import io.fusionauth.http.log.LoggerFactory;
-
 /**
  * An interface defining the HTTP unexpected exception handler contract.
  *
@@ -30,9 +28,8 @@ public interface HTTPUnexpectedExceptionHandler {
    * The intent is that this provides additional flexibility on the status code and the logging behavior when an unexpected exception
    * caught.
    *
-   * @param loggerFactory the configured logger factory.
-   * @param t             the unexpected exception to handle.
+   * @param t the unexpected exception to handle.
    * @return the desired HTTP status code. Note that if the response has already been committed this will be ignored.
    */
-  int handle(LoggerFactory loggerFactory, Throwable t);
+  int handle(Throwable t);
 }

src/main/java/io/fusionauth/http/server/internal/HTTPWorker.java

@@ -270,7 +270,7 @@ public void run() {
     } catch (Throwable e) {
       var status = Status.InternalServerError;
       try {
-        status = configuration.getUnexpectedExceptionHandler().handle(logger, e);
+        status = configuration.getUnexpectedExceptionHandler().handle(e);
       } catch (Throwable ignore) {
       }