Apply suggestions from code review

Rename `begunAt` to `startedAt` and `creators` to `authors`

Author: hkamran80

src/series/getters.ts

@@ -31,28 +31,28 @@ export const getSeriesTitle = ($seriesPage: SeriesPage): string => {
   return $seriesPage("h2.heading").text().trim();
 };
 
-export const getSeriesCreators = (
+export const getSeriesAuthors = (
   $seriesPage: SeriesPage
-): Series["creators"] => {
-  const creatorLinks = $seriesPage("dl.meta a[rel=author]");
-  const creators: Author[] = [];
+): Series["authors"] => {
+  const authorLinks = $seriesPage("dl.meta a[rel=author]");
+  const authors: Author[] = [];
 
   if (
     $seriesPage("dl.meta > dd:nth-of-type(1)").text().trim() === "Anonymous"
   ) {
     return "Anonymous";
   }
 
-  if (creatorLinks.length !== 0) {
-    creatorLinks.each((i, element) => {
+  if (authorLinks.length !== 0) {
+    authorLinks.each((i, element) => {
       const url = element.attribs.href;
       const [, username, pseud] = url.match(/users\/(.+)\/pseuds\/(.+)/)!;
 
-      creators.push({ username: username, pseud: decodeURI(pseud) });
+      authors.push({ username: username, pseud: decodeURI(pseud) });
     });
   }
 
-  return creators;
+  return authors;
 };
 
 export const getSeriesDescription = (

src/series/index.ts

@@ -1,7 +1,7 @@
 import { loadSeriesPage } from "src/page-loaders";
 import { Series } from "types/entities";
 import {
-  getSeriesCreators,
+  getSeriesAuthors,
   getSeriesBookmarkCount,
   getSeriesCompletionStatus,
   getSeriesDescription,
@@ -27,9 +27,9 @@ export const getSeries = async ({
   return {
     id: seriesId,
     name: getSeriesTitle(seriesPage),
-    begunAt: getSeriesPublishDate(seriesPage),
+    startedAt: getSeriesPublishDate(seriesPage),
     updatedAt: getSeriesUpdateDate(seriesPage),
-    creators: getSeriesCreators(seriesPage),
+    authors: getSeriesAuthors(seriesPage),
     description: getSeriesDescription(seriesPage),
     notes: getSeriesNotes(seriesPage),
     words: getSeriesWordCount(seriesPage),

tests/series.test.ts

@@ -375,7 +375,7 @@ describe("Fetches series information", () => {
 
   test("Fetches author with username Anonymous", async () => {
     const series = await getSeries({ seriesId: "2946579" });
-    expect(series.creators).toBe("Anonymous");
+    expect(series.authors).toBe("Anonymous");
   });
 
   describe("Fetches series title", () => {

types/entities.ts

@@ -50,9 +50,9 @@ export interface SeriesWorkSummary
 export interface Series {
   id: string;
   name: string;
-  begunAt: string;
+  startedAt: string;
   updatedAt: string;
-  creators: WorkSummary["authors"];
+  authors: WorkSummary["authors"];
   description: string | null;
   notes: string | null;
   words: number;