[request] improvement: use null coalescing operator

connorhu · connorhu · commit f145eaed44ca · 2024-04-09T09:05:54.000+02:00
diff --git a/lib/request/sfWebRequest.class.php b/lib/request/sfWebRequest.class.php
@@ -663,7 +663,7 @@ public function getPathInfoArray()
      */
     public function getMimeType($format)
     {
-        return isset($this->formats[$format]) ? $this->formats[$format][0] : null;
+        return $this->formats[$format][0] ?? null;
     }
 
     /**
@@ -862,7 +862,7 @@ public function getClientIp($proxy = true)
             }
 
             if ($this->getOption('trust_proxy') && ($ip = $this->getForwardedFor())) {
-                return isset($ip[0]) ? trim($ip[0]) : '';
+                return trim($ip[0] ?? '');
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -663,7 +663,7 @@ public function getPathInfoArray()`
`663`	`663`	`*/`
`664`	`664`	`public function getMimeType($format)`
`665`	`665`	`{`
`666`		`- return isset($this->formats[$format]) ? $this->formats[$format][0] : null;`
	`666`	`+ return $this->formats[$format][0] ?? null;`
`667`	`667`	`}`
`668`	`668`
`669`	`669`	`/**`
`@@ -862,7 +862,7 @@ public function getClientIp($proxy = true)`
`862`	`862`	`}`
`863`	`863`
`864`	`864`	`if ($this->getOption('trust_proxy') && ($ip = $this->getForwardedFor())) {`
`865`		`- return isset($ip[0]) ? trim($ip[0]) : '';`
	`865`	`+ return trim($ip[0] ?? '');`
`866`	`866`	`}`
`867`	`867`	`}`
`868`	`868`