[database] improvement: use null coalescing operator

connorhu · connorhu · commit 9e76cb990a36 · 2024-04-09T08:56:28.000+02:00
diff --git a/lib/database/sfDatabaseManager.class.php b/lib/database/sfDatabaseManager.class.php
@@ -92,12 +92,7 @@ public function setDatabase($name, sfDatabase $database)
      */
     public function getDatabase($name = 'default')
     {
-        if (isset($this->databases[$name])) {
-            return $this->databases[$name];
-        }
-
-        // nonexistent database name
-        throw new sfDatabaseException(sprintf('Database "%s" does not exist.', $name));
+        return $this->databases[$name] ?? throw new sfDatabaseException(sprintf('Database "%s" does not exist.', $name));
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -92,12 +92,7 @@ public function setDatabase($name, sfDatabase $database)`
`92`	`92`	`*/`
`93`	`93`	`public function getDatabase($name = 'default')`
`94`	`94`	`{`
`95`		`- if (isset($this->databases[$name])) {`
`96`		`- return $this->databases[$name];`
`97`		`- }`
`98`		`-`
`99`		`- // nonexistent database name`
`100`		`- throw new sfDatabaseException(sprintf('Database "%s" does not exist.', $name));`
	`95`	`+ return $this->databases[$name] ?? throw new sfDatabaseException(sprintf('Database "%s" does not exist.', $name));`
`101`	`96`	`}`
`102`	`97`
`103`	`98`	`/**`