Code simplification

Review comments, 
simplification sfBrowserBase ternary and remove useless int cast in sfYmlParser

Co-authored-by: mentalstring <mentalstring@gmail.com>

Author: Tybaze

lib/util/sfBrowserBase.class.php

@@ -911,7 +911,7 @@ public function doClickElement(DOMElement $item, $arguments = array(), $options
     }
     else
     {
-      $queryString = (is_array($arguments)) ? http_build_query($arguments, null, '&') : '';
+      $queryString = is_array($arguments) ? http_build_query($arguments, null, '&') : '';
       $sep = false === strpos($url, '?') ? '?' : '&';
 
       return array($url.($queryString ? $sep.$queryString : ''), 'get', array());

lib/util/sfNamespacedParameterHolder.class.php

@@ -395,7 +395,7 @@ public function __serialize()
   }
 
   /**
-   * Unserializes a sfParameterHolder instance. for PHP 7.4
+   * Unserializes a sfParameterHolder instance for PHP 7.4+
    *
    * @param array $data
    */

lib/util/sfParameterHolder.class.php

@@ -209,7 +209,7 @@ public function __serialize()
   }
 
   /**
-   * Unserializes a sfParameterHolder instance. for PHP 7.4
+   * Unserializes a sfParameterHolder instance for PHP 7.4+
    *
    * @param array $data
    */

lib/view/sfViewParameterHolder.class.php

@@ -193,7 +193,7 @@ public function __serialize()
   }
 
   /**
-   * Unserializes a sfParameterHolder instance. for PHP 7.4
+   * Unserializes a sfParameterHolder instance for PHP 7.4+
    *
    * @param array $data
    */

lib/widget/sfWidgetFormDate.class.php

@@ -70,7 +70,7 @@ public function render($name, $value = null, $attributes = array(), $errors = ar
     }
     else
     {
-      $value = (string) $value == (string) (integer) $value ? (integer) $value : strtotime( (string) $value);
+      $value = (string) $value == (string) (integer) $value ? (integer) $value : strtotime((string) $value);
       if (false === $value)
       {
         $value = $default;

lib/yaml/sfYamlParser.class.php

@@ -421,7 +421,7 @@ protected function parseValue($value)
     {
       $modifiers = isset($matches['modifiers']) ? $matches['modifiers'] : '';
 
-      return $this->parseFoldedScalar($matches['separator'], preg_replace('#\d+#', '', $modifiers), (int) abs((int) $modifiers));
+      return $this->parseFoldedScalar($matches['separator'], preg_replace('#\d+#', '', $modifiers), abs((int) $modifiers));
     }
     else
     {