Remove(legacy): drop PHP v5.3 check for SQLite version match

Author: thePanz

lib/cache/sfSQLiteCache.class.php

@@ -306,7 +306,7 @@ protected function isSqLite3()
     protected function getSqLiteVersion()
     {
         if (null === $this->sqlLiteVersion) {
-            $this->sqlLiteVersion = version_compare(PHP_VERSION, '5.3', '>') ? 3 : 2;
+            $this->sqlLiteVersion = 3;
         }
 
         return $this->sqlLiteVersion;

lib/i18n/sfMessageSource.class.php

@@ -130,7 +130,7 @@ public static function factory($type, $source = '.', $filename = '')
             include_once $filename;
         }
 
-        if (('SQLite' == $type) && version_compare(PHP_VERSION, '5.3', '>')) {
+        if ('SQLite' === $type) {
             $type .= '3';
         }
 

test/unit/i18n/sfMessageSource_SQLiteTest.php

@@ -92,23 +92,12 @@ function init_fixtures($temp)
         "INSERT INTO trans_unit (msg_id, cat_id, id, source, target, translated) VALUES (2, 1, 2, 'another english sentence', 'une autre phrase en français', 1)",
     );
 
-    if (version_compare(PHP_VERSION, '5.3', '>')) {
-        $db = new SQLite3($temp);
-
-        foreach ($queries as $query) {
-            $db->exec($query);
-        }
-
-        $db->close();
-    } else {
-        $db = sqlite_open($temp);
-
-        foreach ($queries as $query) {
-            sqlite_query($query, $db);
-        }
-
-        sqlite_close($db);
+    $db = new SQLite3($temp);
+    foreach ($queries as $query) {
+        $db->exec($query);
     }
 
+    $db->close();
+
     return sfMessageSource::factory('SQLite', 'sqlite://localhost/'.$temp);
 }