fixup! fix(test): exit code of lime test

Author: alquerci

lib/vendor/lime/lime.php

@@ -161,6 +161,10 @@ private function determineAndPrintStateOfTestSuite(): int
       return self::STATE_FAIL;
     }
 
+    if ($this->results['stats']['errors']) {
+      return self::STATE_FAIL;
+    }
+
     if (self::STATE_PASS === $planState) {
       $this->output->green_bar("# Looks like everything went fine.");
     }

test/unit/vendor/lime/fixtures/pass_with_one_error.php

@@ -2,7 +2,7 @@
 
 require_once __DIR__.'/../../../../bootstrap/unit.php';
 
-error_reporting(-1);
+error_reporting(E_USER_ERROR);
 
 $test = new lime_test(null, [
     'error_reporting' => true,

test/unit/vendor/lime/fixtures/pass_with_one_throw_exception.php

@@ -0,0 +1,9 @@
+<?php
+
+require_once __DIR__.'/../../../../bootstrap/unit.php';
+
+$test = new lime_test();
+
+throw new LogicException('some exception message');
+
+$test->is(true, true);

test/unit/vendor/lime/limeTest.php

@@ -43,7 +43,7 @@ public function __construct()
     }
 }
 
-$test = new lime_test(18);
+$test = new lime_test(20);
 
 $files = [
     __DIR__.'/fixtures/failed.php',
@@ -113,6 +113,21 @@ public function __construct()
 $message = 'with at least one error will fail the overall test suite';
 whenExecuteHarnessWithFilesWillHaveResultAndOutput($test, $files, $expectedOverallSucceed, $expectedOutput, $message);
 
+$files = [__DIR__.'/fixtures/pass_with_one_throw_exception.php'];
+$expectedOverallSucceed = false;
+$expectedOutput = <<<'EOF'
+test/unit/vendor/lime/fixtures/pass_with_one_throw_exception.........errors
+    Errors:
+    - LogicException: some exception message
+Failed Test                     Stat  Total   Fail  Errors  List of Failed
+--------------------------------------------------------------------------
+/pass_with_one_throw_exception     1      0      0      1
+Failed 1/1 test scripts, 0.00% okay. 0/0 subtests failed, 0.00% okay.
+
+EOF;
+$message = 'with at least one thrown Exception will fail the overall test suite';
+whenExecuteHarnessWithFilesWillHaveResultAndOutput($test, $files, $expectedOverallSucceed, $expectedOutput, $message);
+
 
 $name = 'pass';
 $expectedStatusCode = 0;