fix: OAuthFactory node definition, DefinitionDecorator deprecated in SF4

Author: dkarlovi

DependencyInjection/Security/Factory/OAuthFactory.php

@@ -15,9 +15,7 @@
 
 use Symfony\Bundle\SecurityBundle\DependencyInjection\Security\Factory\SecurityFactoryInterface;
 use Symfony\Component\Config\Definition\Builder\NodeDefinition;
-use Symfony\Component\DependencyInjection\ChildDefinition;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
-use Symfony\Component\DependencyInjection\DefinitionDecorator;
 use Symfony\Component\DependencyInjection\Reference;
 
 /**
@@ -32,24 +30,21 @@ class OAuthFactory implements SecurityFactoryInterface
      */
     public function create(ContainerBuilder $container, $id, $config, $userProvider, $defaultEntryPoint)
     {
-        $providerId = 'security.authentication.provider.fos_oauth_server.'.$id;
-        if (class_exists(ChildDefinition::class)) {
-            $definition = new ChildDefinition('fos_oauth_server.security.authentication.provider');
-        } else {
-            $definition = new DefinitionDecorator('fos_oauth_server.security.authentication.provider');
+        // NOTE: done like this to avoid PHPStan complaining about a missing class for both Symfony v3 and Symfony v4
+        $definitionDecorator = 'Symfony\\Component\\DependencyInjection\\DefinitionDecorator';
+        $childDefinition = 'Symfony\\Component\\DependencyInjection\\ChildDefinition';
+        $definitionClass = $childDefinition;
+        if (class_exists($definitionDecorator)) {
+            $definitionClass = $definitionDecorator;
         }
+
+        $providerId = 'security.authentication.provider.fos_oauth_server.'.$id;
         $container
-            ->setDefinition($providerId, $definition)
+            ->setDefinition($providerId, new $definitionClass('fos_oauth_server.security.authentication.provider'))
             ->replaceArgument(0, new Reference($userProvider));
 
         $listenerId = 'security.authentication.listener.fos_oauth_server.'.$id;
-
-        if (class_exists(ChildDefinition::class)) {
-            $definition = new ChildDefinition('fos_oauth_server.security.authentication.listener');
-        } else {
-            $definition = new DefinitionDecorator('fos_oauth_server.security.authentication.listener');
-        }
-        $container->setDefinition($listenerId, $definition);
+        $container->setDefinition($listenerId, new $definitionClass('fos_oauth_server.security.authentication.listener'));
 
         return [$providerId, $listenerId, 'fos_oauth_server.security.entry_point'];
     }